Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the ibm tool adapter’s standard-result generation so withItems: false no longer causes an internal TypeError and act failure, aligning IBM reporting behavior with the documented “totals-only” output when itemization is disabled.
Changes:
- Ensure trimmed IBM native results always return an
itemsarray (empty whenwithItemsis off) to avoidundefineditem lists. - Guard standard-instance population behind
withItemsso totals are produced without rule/instance details when itemization is disabled. - Keep the emitted
tests/ibm.jssynchronized with the TypeScript source.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ibm.ts | Fixes withItems: false standard-results path by returning items: [] when not itemizing and only iterating items when withItems is enabled. |
| tests/ibm.js | Mirrors the TypeScript fix in the committed emitted JavaScript so runtime behavior matches the source. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the bug in the module that runs the
ibmrule engine. This correction resolves issue #124. After the correction, as documented inREADME.md, a report from theibmrule engine when thewithItemsoption is turned off includes totals for violations (ordinal severity 2) and for recommendations (ordinal severity 0), but no information about the violated rules.