CI: bump GitHub Actions off deprecated Node.js 20 (#3) - #4
Conversation
Move pinned action majors to Node 24-native versions so the workflow keeps working once GitHub removes the Node 20 runtime: - actions/checkout v4 -> v5 - actions/setup-node v4 -> v5 - actions/upload-artifact v4 -> v5 - actions/download-artifact v4 -> v5 - pnpm/action-setup v4 -> v6 - softprops/action-gh-release v2 -> v3 No workflow logic changes. Closes #3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
upload-artifact@v5 still targets Node 20; bump the artifact actions to their current majors (upload v7, download v8, same artifact backend) so no action runs on the deprecated runtime. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abd35dd4d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Upload static artifact | ||
| uses: actions/upload-artifact@v4 | ||
| uses: actions/upload-artifact@v5 |
There was a problem hiding this comment.
This does not actually move the artifact steps off Node 20: the official metadata for actions/upload-artifact@v5 declares runs.using: node20, and the paired actions/download-artifact@v5 does the same, while Node 24 is declared starting at upload-artifact@v6 and download-artifact@v7. Because this upload step runs on every PR/push and the download step runs on main deploys, the workflow remains on the deprecated Node 20 runtime in the exact paths this change is intended to fix.
Useful? React with 👍 / 👎.
1 participant
Closes #3.
Bumps pinned GitHub Actions majors to Node 24-native versions so the workflow keeps working once GitHub removes the Node 20 runtime from runners.
actions/checkoutactions/setup-nodeactions/upload-artifactactions/download-artifactpnpm/action-setupsoftprops/action-gh-releaseNo workflow logic changes.
upload-artifact/download-artifactbumped together to stay on the same artifact backend;pnpm/action-setup@v6still accepts the existingversion/run_installinputs and runs beforesetup-node(which caches pnpm).The PR
buildjob exercises checkout/setup-node/pnpm-setup/upload at their new versions;download-artifactandaction-gh-releaserun on themain/tag paths after merge.🤖 Generated with Claude Code