Publish Shell Rolling validation cases and refresh QA coverage - #172
Conversation
The Shell Rolling engine is now covered by 87 unit tests (YurMil/Shell-Rolling-Master#11). Publish the hand-derived reference cases from that suite on the documentation page, as the Blind Flange and Dished End pages already do: cylinder from OD and ID, K-factor and gap sensitivity, the concentric cone development, and rejected input. The page also claimed the tool does not handle cones; it develops concentric and eccentric cones, so the FAQ, structured data and assumptions are corrected. The QA strategy page's coverage table now reflects Shell Rolling tests and the deploy test gates added for Pipe Notch and PDF Master (#152). Refs #153, #152 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae09706753
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Closes the documentation part of #153 and records the outcome of #152.
2πtfor any K-factorMerge order
The coverage table states that tests gate deploys for all three apps. Please merge this after:
Not in scope
The translated copies of this page (de/es/et/ru/ua) never received the English theory and worked-example sections added in #150, so the validation cases are English-only for now, consistent with the other calculator pages. The translated FAQ still carries the outdated cone answer; that is left for a translation pass.
Verification
DOCUSAURUS_ONBROKENLINKS=throw docusaurus build --locale en— succeeds.π·1983.2 − 2 = 6228.41,ρo = 9965.46,θ = 35.8213°, etc.) and matched against the test suite.🤖 Generated with Claude Code