Remove noncanonical definitions. - #15
Merged
Merged
Conversation
Owner
|
This appeases the `-Wnoncanonical-monad-instances` warning. A future GHC release will treat noncanonical definitions as errors. See haskell/core-libraries-committee#328.
L0neGamer
force-pushed
the
no-return-refactor
branch
from
July 31, 2026 19:15
bbc4803 to
a72cc15
Compare
Contributor
Author
|
What is your support window? This should support all the way back to GHC 7.10. I've amended the base bounds but I cannot test it locally, 7.10 doesn't seem to work for me. |
Owner
It's "whatever CI is configured to build with". Previously it included Anyway, the CI is green, I'll merge the PR shortly. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appeases the
-Wnoncanonical-monad-instanceswarning. A future GHC release will treat noncanonical definitions as errors. See haskell/core-libraries-committee#328.