fix(zaparoo): restore menu static background

[wizzomafizzo]

Summary

• clear stale native CRT control words before FPGA reconfiguration
• release native video state when initializing the menu core
• prevent prior core frame metadata from replacing the menu noise background with garbage

Validation

• git diff --check
• ARM build skipped: cross-toolchain unavailable in current shell

Summary by CodeRabbit

• Bug Fixes
  • Improved video-state cleanup during FPGA reconfiguration to prevent stale native video controls from affecting newly loaded cores.
  • Ensured the menu display is safely released before alternate launcher and framebuffer terminal setup.

[coderabbitai]

Warning

Review limit reached

Next included review available in 53 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: da395795-8c5d-4454-9a1d-4b232dddff0a

📥 Commits

Reviewing files that changed from the base of the PR and between 195b497 and d73726b.

📒 Files selected for processing (2)

• support/zaparoo/alt_launcher.cpp
• support/zaparoo/alt_launcher.h

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ba1668db-8bd9-4289-ad4c-285b794e0808

📥 Commits

Reviewing files that changed from the base of the PR and between 8f55057 and 195b497.

📒 Files selected for processing (3)

• support/zaparoo/alt_launcher.cpp
• support/zaparoo/alt_launcher.h
• user_io.cpp

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds a public native video release function, calls it during menu initialization, and clears native video control words whenever the alternate launcher shuts down.

Changes

Native video reset

Layer / File(s)	Summary
Menu video release support/zaparoo/alt_launcher.h, support/zaparoo/alt_launcher.cpp, user_io.cpp	The new zaparoo_native_video_release() function clears the native video control block. Menu initialization calls it before alternate-launcher or framebuffer-terminal setup.
Launcher shutdown reset support/zaparoo/alt_launcher.cpp	alt_launcher_shutdown() clears the native video control block before checking launcher process state.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 195b4

The PR restores the menu’s static background by clearing stale video state during initialization and reconfiguration; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: asturur

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: restoring the menu static background in Zaparoo.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

⚔️ Resolve merge conflicts 💡

• Resolve merge conflict in branch fix/zaparoo-menu-static-background

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/zaparoo-menu-static-background

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}