fix(input): reject input macro keys ending in a repeat suffix - #68
Merged
Conversation
parseSuffixRepeat splits a braced input macro token at the last '*'
followed by digits. When the content carries two repeat suffixes the
leftover key name still ends in one, so expandInputMacroExt emitted a
"{name}" token that Command.String() could not write back: re-reading it
stripped the suffix a second time.
"{*1*1}" serialised to "{*1}" and failed to reparse, while "{a*1*2}"
serialised to two "{a*1}" tokens that read back as two "a" tokens.
Reject the ambiguous form at parse time instead of producing a token that
cannot round-trip. Names where '*' is literal ("{ctrl+*}", "{a*b}",
"{a*0}", "{*}") are unaffected.
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseSuffixRepeatsplits a braced input macro token at the last*followed by digits, so content carrying two repeat suffixes left a key name that still ended in one.expandInputMacroExtthen emitted a{name}token thatCommand.String()could not write back, because re-reading it stripped the suffix a second time.**input.keyboard:{*1*1}serialised to**input.keyboard:{*1}, which failed to reparse withErrInputMacroEmptyKey;{a*1*2}serialised to two{a*1}tokens that read back as twoatokens.ErrInputMacroAmbiguousKeyrather than producing a token that cannot round-trip. Key names where*is literal ({ctrl+*},{a*b},{a*0},{*}) are unaffected, since the check only fires when the leftover name would itself be re-split.FuzzCommandStringcorpus entry from the nightly run as a regression seed, plus error and positive cases covering the surrounding*handling.All 23 open nightly fuzz issues are this one crash, re-reported each night.
Closes #22, closes #30, closes #38, closes #39, closes #40, closes #41,
closes #42, closes #43, closes #45, closes #47, closes #48, closes #52,
closes #53, closes #55, closes #56, closes #57, closes #58, closes #59,
closes #60, closes #61, closes #62, closes #64, closes #65