Patch 03 - #5802
Open
SteelBlueZK wants to merge 2 commits into
Open
Conversation
sprunk
approved these changes
Jul 30, 2026
Member
There was a problem hiding this comment.
Personally I think the error is good (since the mod is passing an incorrect value and should just stop doing that) so perhaps the ideal improvement would have been to make it more helpful:
if not ud then
error("Spring.Utilities.isComm() called with invalid arg: " .. tostring(ud))
endBut as-is the PR is consistent with how everything is polluted with a billion nil checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #5801
This essentially silent fails, "If this Unitdef is not a unitdef, then it is not a commander"