fix(cuqdyn-rs): correct the p3/p4 swap in the Lotka-Volterra model - #15
Open
davidrpenas wants to merge 1 commit into
Open
fix(cuqdyn-rs): correct the p3/p4 swap in the Lotka-Volterra model#15davidrpenas wants to merge 1 commit into
davidrpenas wants to merge 1 commit into
Conversation
The compiled model computed dy2 = (p3*y0 - p2)*y1, while prob_mod_dynamics_LV.m defines dy2 = (p3*y1 - p4)*y2: p3 and p4 were swapped, so parameters fitted with the fully-observed LV example were not comparable component-wise with MATLAB. The expression variant in lotka_volterra_expr() carried the same swap, and the unit test and test_ode_solver's lotka-volterra scenario encoded it; the expected trajectories are unchanged, only which slot holds the interaction rate. The lv2_partobs example was never affected. Two clippy-driven rewrites in models.rs had also turned panic format captures into literal text; restored the interpolation. cargo test and the ctest suite pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
davidrpenas
force-pushed
the
fix/lv-model-and-panics
branch
from
September 7, 2026 12:01
cf31d17 to
4f2ae86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiled model computed dy2 = (p3*y0 - p2)y1, while prob_mod_dynamics_LV.m defines dy2 = (p3y1 - p4)*y2: p3 and p4 were swapped, so parameters fitted with the fully-observed LV example were not comparable component-wise with MATLAB. The expression variant in lotka_volterra_expr() and tests/data carried the same swap, and the unit test and test_ode_solver's inputs encoded it; the expected trajectories are unchanged, only which slot holds the interaction rate. The lv2_partobs example was never affected.
Two clippy-driven rewrites in models.rs had also turned panic format captures into literal text; restored the interpolation. cargo test and the ctest suite pass.