Skip to content

fix: correct readableSectorTags allocation size to prevent heap overflow #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MSSonline wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

fix: correct readableSectorTags allocation size to prevent heap overflow #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb5eaa1
Update create.c
MSSonline Aug 3, 2026
3e85911
Update open.c
MSSonline Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/create.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ AARU_EXPORT void *AARU_CALL aaruf_create(const char *filepath, const uint32_t me
TRACE("Generating random GUID");
generate_random_bytes(ctx->header.guid, GUID_SIZE);

ctx->readableSectorTags = (bool *)malloc(sizeof(bool) * MaxSectorTag);
ctx->readableSectorTags = (bool *)malloc(sizeof(bool) * (MaxSectorTag + 1));

if(ctx->readableSectorTags == NULL)
{
Expand All @@ -371,7 +371,7 @@ AARU_EXPORT void *AARU_CALL aaruf_create(const char *filepath, const uint32_t me
return NULL;
}

memset(ctx->readableSectorTags, 0, sizeof(bool) * MaxSectorTag);
memset(ctx->readableSectorTags, 0, sizeof(bool) * (MaxSectorTag + 1));

// Initialize image info
TRACE("Initializing image info");
Expand Down
4 changes: 2 additions & 2 deletions src/open.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ AARU_EXPORT void *AARU_CALL aaruf_open(const char *filepath, const bool resume_m
TRACE("Opening image version %d.%d", ctx->header.imageMajorVersion, ctx->header.imageMinorVersion);

TRACE("Allocating memory for readable sector tags bitmap");
ctx->readableSectorTags = (bool *)malloc(sizeof(bool) * MaxSectorTag);
ctx->readableSectorTags = (bool *)malloc(sizeof(bool) * (MaxSectorTag + 1));

if(ctx->readableSectorTags == NULL)
{
Expand All @@ -442,7 +442,7 @@ AARU_EXPORT void *AARU_CALL aaruf_open(const char *filepath, const bool resume_m
return NULL;
}

memset(ctx->readableSectorTags, 0, sizeof(bool) * MaxSectorTag);
memset(ctx->readableSectorTags, 0, sizeof(bool) * (MaxSectorTag + 1));

TRACE("Setting up image info");

Expand Down