fix - _parseJSException can return any type of exception - #193
Open
martin-mastalko-4max wants to merge 1 commit into
Open
fix - _parseJSException can return any type of exception#193martin-mastalko-4max wants to merge 1 commit into
martin-mastalko-4max wants to merge 1 commit into
Conversation
GrishMahat
added a commit
to GrishMahat/flutter_js
that referenced
this pull request
Aug 20, 2026
… upstream PRs 191+193 - Replace prebuilt/jitpack QuickJS 2021 engine with vendored quickjs-ng 0.14.0 built via CMake on Android/Linux/Windows; prebuilt dylib on macOS - Keep JSC bindings for ABI but always run QuickJsRuntime2 - Rewrite platform plugins as stubs; drop dead FlutterJs channel engine - Apply PR abner#191: drop apply plugin kotlin-android, Java 17 + kotlin compilerOptions DSL, Gradle wrapper 8.14.4, Flutter >=3.24.0 - Apply PR abner#193: _parseJSException typed as final - Untrack pubspec.lock; add personal-fork notice to README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When _parseJSException returned any type other than JSError, the flutter_js package crashed. This is fixed by removing the explicit type.