Skip to content

Fix Version.__hash__ to be consistent with __eq__. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
selsky wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Version.__hash__ to be consistent with __eq__. #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/univers/maven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ def __eq__(self, other):
return self.__cmp__(other) == 0

def __hash__(self):
return hash(self._unparsed)
return hash(self._parsed)

def __lt__(self, other):
return self.__cmp__(other) < 0
Expand Down Expand Up @@ -492,6 +492,9 @@ def _new_list(self, l):
return sublist

def _normalize(self, l):
for i, item in enumerate(l):
if isinstance(item, list):
self._normalize(item)
for item in l[::-1]:
if not item:
l.pop()
Expand Down