Skip to content

feat: a toString() method for enumerated values in Java - #103

Merged
mttrbrts merged 7 commits into
accordproject:mainfrom
subhajit20:feature/javavisitor_enumDeclaration_toString
Aug 4, 2026
Merged

feat: a toString() method for enumerated values in Java#103
mttrbrts merged 7 commits into
accordproject:mainfrom
subhajit20:feature/javavisitor_enumDeclaration_toString

Conversation

@subhajit20

@subhajit20 subhajit20 commented Mar 31, 2024

Copy link
Copy Markdown
Contributor

Closes accordproject/concerto#100

Changes

  • override the toString method inside the javavisitor enumDeclaration function
  • Updated snapshots for required changes
  • Added test for the changes

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Subhajit Ghosh <subhajitstd07@gmail.com>
Signed-off-by: Subhajit Ghosh <subhajitstd07@gmail.com>
Signed-off-by: Subhajit Ghosh <subhajitstd07@gmail.com>
@subhajit20

Copy link
Copy Markdown
Contributor Author

hey @mttrbrts @sanketshevkar can you please review and give some feedback

Signed-off-by: Subhajit Ghosh <subhajitstd07@gmail.com>
@coveralls

coveralls commented Mar 31, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 98.739% (+0.001%) from 98.738%
when pulling 7c14d70 on subhajit20:feature/javavisitor_enumDeclaration_toString
into a2463e0 on accordproject:main.

Comment thread test/codegen/__snapshots__/codegen.js.snap Outdated
@sanketshevkar
sanketshevkar requested a review from mttrbrts April 1, 2024 06:12
@subhajit20
subhajit20 force-pushed the feature/javavisitor_enumDeclaration_toString branch from 18522a9 to 7c14d70 Compare April 3, 2024 03:09
@DianaLease
DianaLease requested a review from dselman April 3, 2024 12:16
@mttrbrts

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

@mttrbrts mttrbrts changed the title Added [Feature]: a toString() method for enumerated values in Java feat: a toString() method for enumerated values in Java Aug 4, 2026
Merges upstream main into feature/javavisitor_enumDeclaration_toString
to resolve conflicts. Snapshot file was regenerated using current main's
test naming convention ('versioned CTO') with the new toString() output
included.

Signed-off-by: Matt Roberts <mttrbrts@users.noreply.github.com>
Java requires a semicolon terminating the enum constant list before any
method bodies. Without it, javac errors with '<identifier> expected' on
the @OverRide annotation.

Signed-off-by: Matt Roberts <mttrbrts@users.noreply.github.com>
Empty enums (zero constants) also need a semicolon before method
declarations per the Java Language Specification (JLS 8.9.1).

Signed-off-by: Matt Roberts <mttrbrts@users.noreply.github.com>
@mttrbrts
mttrbrts enabled auto-merge (squash) August 4, 2026 12:36
@mttrbrts
mttrbrts merged commit 71a8939 into accordproject:main Aug 4, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Provide a toString() method for enumerated values in Java

5 participants