Skip to content

Fix Core tagging/release workflow #613

Description

@devksingh4

Currently, when the release checker checks for a new package.json version, it immediately creates the tag and the other pipeline takes over to run the release: https://github.com/acm-uiuc/core/blob/main/.github/workflows/release.yml

However, if the released code fails to build, then we have a tag created with broken code. We should instead first build/unit test the code, then create the tag, and then run the release stuff. This most likely requires using multiple stages in the github actions, etc.

Ideally, we also modify the Github action so that if the previous commit failed to deploy for the tag, then it will run it, even if the version didn't change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggithub_actionsPull requests that update GitHub Actions code

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions