Create Reflow Tests - #2429
Conversation
First draft of the content reflow test
❌ Deploy Preview for act-rules failed.
|
|
I know I have to add references and definitions to the tests - TBD |
|
|
||
| #### Failed Example 2 | ||
|
|
||
| Navigation items removed instead of adapted. |
There was a problem hiding this comment.
This looks like a repetition of the first example. Does this add or clarify something that the first example doesn't cover?
|
|
||
| #### Failed Example 4 | ||
|
|
||
| Content moved off-screen and not reachable. |
There was a problem hiding this comment.
It looks to me like this content would not be available at any viewport size, this is also a common valid technique for applying text only available to AT.
There was a problem hiding this comment.
Yes, we need a default state where this is available. In any case, this also seems to contradict the expectation
| Each target element: | ||
| Retains all content and functionality when viewed at 320 CSS pixels; and | ||
| - Does not hide, remove, or make content unavailable as a result of viewport constraints, zoom, or responsive behaviour; and | ||
| - Ensures that any content that is visually hidden at this viewport size is still programmatically available and accessible to users. |
There was a problem hiding this comment.
With the examples that you included that always hide content, I feel like we may need to define a way to compare before and after. For example, should we compare content at 1280 vs 320?
There was a problem hiding this comment.
I'd agree with @G0dwin. We first need to define the default view
|
|
||
| ## Applicability | ||
|
|
||
| This rule applies to any element containing visible content or functional components. It is rendered when the viewport is set to 320 CSS pixels in the orientation of the text. |
There was a problem hiding this comment.
I would encourage following the wording of the requirement.
As described in the understanding doc:
This criterion requires non-excepted sections of content that are written in horizontal languages reflow when narrowed to a width equivalent to 320 CSS pixels. Similarly, sections of content that are written in vertical languages (which are not as commonly used on the web and so will be used much less frequently in examples) need to be able to reflow when rendered at a height equivalent to 256 CSS pixels.
the orientation of the text is relevant in determining the applicable requirement. As currently written, the text appears to imply that the requirement is always 320 CSS pixels, even for vertically oriented content, which is inconsistent with the criterion.
| Each target element: | ||
| Retains all content and functionality when viewed at 320 CSS pixels; and | ||
| - Does not hide, remove, or make content unavailable as a result of viewport constraints, zoom, or responsive behaviour; and | ||
| - Ensures that any content that is visually hidden at this viewport size is still programmatically available and accessible to users. |
There was a problem hiding this comment.
I'd agree with @G0dwin. We first need to define the default view
|
|
||
| Each target element: | ||
| Retains all content and functionality when viewed at 320 CSS pixels; and | ||
| - Does not hide, remove, or make content unavailable as a result of viewport constraints, zoom, or responsive behaviour; and |
There was a problem hiding this comment.
I'd say this is ambiguous. For example, a navigation menu that is expanded by default on desktop but programmatically hidden on mobile until the user activates the hamburger menu could be interpreted as violating this requirement. I think we need more precise wording than "hide" to avoid unintentionally including these common responsive design patterns
|
|
||
| ## Applicability | ||
|
|
||
| This rule applies to any element containing visible content or functional components. It is rendered when the viewport is set to 320 CSS pixels in the orientation of the text. |
There was a problem hiding this comment.
We can refine the applicability even further. For example, it could apply only to visible content with:
- a height of at least 320 CSS pixels on pages with vertical scrolling
- a height of at least 256 CSS pixels on pages with horizontal scrolling
This would align the applicability more closely with the corresponding reflow requirements
|
|
||
| #### Passed Example 1 | ||
|
|
||
| Content reflows but remains fully available. |
There was a problem hiding this comment.
| Content reflows but remains fully available. | |
| Content remains fully available after reflow. |
My feeling is that the use of "but" gives the sentence a negative tone
| Each target element: | ||
| Retains all content and functionality when viewed at 320 CSS pixels; and | ||
| - Does not hide, remove, or make content unavailable as a result of viewport constraints, zoom, or responsive behaviour; and | ||
| - Ensures that any content that is visually hidden at this viewport size is still programmatically available and accessible to users. |
There was a problem hiding this comment.
Also, in the first bullet we are saying not to hide or remove the content, whereas here we're saying that content that cannot be hidden (and is visually hidden) is programmatically available. I understand that the intent (even though I don't agree) is for the first bullet to cover programmatically hidden content and the second to cover only visually hidden content. However, that distinction isn't clear from the current wording
|
|
||
| #### Failed Example 4 | ||
|
|
||
| Content moved off-screen and not reachable. |
There was a problem hiding this comment.
Yes, we need a default state where this is available. In any case, this also seems to contradict the expectation
| ```html | ||
| <div role="presentation"> | ||
| Decorative content only. | ||
| </div> | ||
| ``` |
There was a problem hiding this comment.
There is no mention of decorative content in either the SC or this rule. As written, this cannot be marked as inapplicable. Also, even if we decide to move in that direction (and I'm not convinced we should), I would replace the text with a decorative image, since the concept of "decorative text" is debatable
| #### Inapplicable Example 4 | ||
|
|
||
| Content that is replaced by an equivalent alternative. The full content is replaced with an equivalent that preserves meaning. | ||
|
|
||
| ```html | ||
| <p class="mobile">Short summary version</p> | ||
| <p class="desktop">Full detailed version</p> | ||
| ``` |
There was a problem hiding this comment.
There is no mention of alternative in this rule. As written, this cannot be marked as inapplicable.
|
|
||
| ## Applicability | ||
|
|
||
| This rule applies to any element containing visible content or functional components. It is rendered when the viewport is set to 320 CSS pixels in the orientation of the text. |
There was a problem hiding this comment.
It is rendered when the viewport is set to 320 CSS pixels in the orientation of the text.
the current wording implies that if the content is hidden at 320 CSS pixels, the rule is not applicable, which isn't our intent
First draft of the content reflow test
Creating the first draft of a reflow test, one of three new rules
Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve