Fix curl installer: BSD sed doesn't support \s - #13
Merged
Conversation
The install script's grep patterns matched on macOS (BSD grep tolerates \s) but the sed prefix-stripping silently failed (BSD sed treats \s as a literal 's'), producing 'Latest version: "tag_name": "v1.2.1' and a malformed download URL — every curl install failed with 'URL rejected: Malformed input to a URL function'. Use POSIX [[:space:]] classes and capture-group extraction instead, and hard-fail with a clear message if the parsed URL isn't https://. Verified end-to-end: the script downloads, mounts, and installs v1.2.1 to /Applications. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer's sed prefix-stripping silently failed on macOS (BSD sed treats
\sas a literals), producing a malformed download URL — every curl install failed withURL rejected: Malformed input to a URL function. grep masked the problem by tolerating\s.Switched to POSIX
[[:space:]]classes with capture-group extraction, plus a hardhttps://sanity check on the parsed URL.Verified end-to-end on macOS: downloads, mounts, and installs v1.2.1 to /Applications.
No release is triggered by this merge (install.sh is fetched from
mainraw, so the fix is live for users the moment it lands).🤖 Generated with Claude Code