Skip to content

fix(types): export structured error details #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 4 commits into from
Aug 25, 2026
+117 −0
Merged

fix(types): export structured error details #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c429a08
feat(oauth): add secure buyer authorization helpers
bokelley Aug 24, 2026
94edd61
Merge remote-tracking branch 'origin/main' into issue-1031-oauth
bokelley Aug 25, 2026
6a1d35c
fix(types): export structured error details
bokelley Aug 25, 2026
b53fdc9
test(types): verify error detail exports
bokelley Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/adcp/types/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,24 @@
"RequestProposalsRequest",
"RequestProposalsResponse",
"UnsupportedRefinementDimensionDetails",
# Structured protocol error details
"AccessibilityViolationDetails",
"AccountMovedDetails",
"AccountSetupRequiredDetails",
"ActionNotAllowedDetails",
"ActionNotAllowedReason",
"AgentPermissionDeniedDetails",
"AudienceTooSmallDetails",
"BillingNotPermittedForAgentDetails",
"BillingNotSupportedDetails",
"BudgetTooLowDetails",
"ConflictDetails",
"CreativeRejectedDetails",
"PolicyViolationDetails",
"RateLimitedDetails",
"StaleResponseDetails",
"VendorErrorCodeRegistry",
"VersionUnsupportedDetails",
# A2UI types
"A2UiComponent",
"A2UiSurface",
Expand Down Expand Up @@ -1080,14 +1098,17 @@ def __dir__() -> list[str]:
AcceptedLoss,
AcceptProposalRequest,
AcceptProposalResponse,
AccessibilityViolationDetails,
Account,
AccountAuthorization,
AccountIdReference,
AccountMovedDetails,
AccountReference,
AccountReferenceById,
AccountReferenceByNaturalKey,
AccountResponse,
AccountScope,
AccountSetupRequiredDetails,
AccountWithAuthorization,
AcquireRightsAcquiredResponse,
AcquireRightsErrorResponse,
Expand All @@ -1097,6 +1118,8 @@ def __dir__() -> list[str]:
AcquireRightsResponse,
AcquireRightsResponse1,
Action,
ActionNotAllowedDetails,
ActionNotAllowedReason,
ActivateSignalErrorResponse,
ActivateSignalRequest,
ActivateSignalResponse,
Expand All @@ -1107,6 +1130,7 @@ def __dir__() -> list[str]:
AgentConfig,
AgentDeployment,
AgentDestination,
AgentPermissionDeniedDetails,
AggregatedTotals,
AiTool,
Artifact,
Expand All @@ -1120,6 +1144,7 @@ def __dir__() -> list[str]:
AssignedPackage,
Assignments,
AudienceSource,
AudienceTooSmallDetails,
AudioContent,
AudioFormatAsset,
AudioFormatGroupAsset,
Expand All @@ -1137,12 +1162,15 @@ def __dir__() -> list[str]:
AvailableMetric,
AvailablePackage,
AvailableReportingFrequency,
BillingNotPermittedForAgentDetails,
BillingNotSupportedDetails,
BothPreviewRender,
BrandIdentity,
BrandReference,
BrandSource,
BriefAsset,
BriefFormatAsset,
BudgetTooLowDetails,
BuildCreativeCreative,
BusinessEntity,
BusinessEntityResponse,
Expand Down Expand Up @@ -1209,6 +1237,7 @@ def __dir__() -> list[str]:
ComplyTestControllerRequest,
ComplyTestControllerResponse,
ComplyTestControllerResponse1,
ConflictDetails,
ConsentBasis,
Contact,
ContentIdType,
Expand Down Expand Up @@ -1260,6 +1289,7 @@ def __dir__() -> list[str]:
CreativeFilters,
CreativeManifest,
CreativePolicy,
CreativeRejectedDetails,
CreativeStatus,
CreativeVariant,
CreditLimit,
Expand Down Expand Up @@ -1571,6 +1601,7 @@ def __dir__() -> list[str]:
PolicyHistory,
PolicyRevision,
PolicySummary,
PolicyViolationDetails,
PostalArea,
PreviewOutputFormat,
PreviewRender,
Expand Down Expand Up @@ -1631,6 +1662,7 @@ def __dir__() -> list[str]:
PushNotificationConfig,
QuartileData,
QuerySummary,
RateLimitedDetails,
ReachUnit,
RealEstateUnit,
Recovery,
Expand Down Expand Up @@ -1712,6 +1744,7 @@ def __dir__() -> list[str]:
SortApplied,
SortDirection,
Source,
StaleResponseDetails,
Status,
StatusSummary,
SyncAccountsAccount,
Expand Down Expand Up @@ -1837,6 +1870,7 @@ def __dir__() -> list[str]:
VcpmFixedRatePricingOption,
VcpmPricingOption,
VehicleUnit,
VendorErrorCodeRegistry,
VendorPricingOptionUnion,
VenueBreakdownItem,
VerifyBrandClaimPayload,
Expand All @@ -1852,6 +1886,7 @@ def __dir__() -> list[str]:
VerifyBrandClaimsResponseBulk,
VerifyBrandClaimsSignedResponse,
VerifyBrandClaimsSignedSuccessPayload,
VersionUnsupportedDetails,
VideoContent,
VideoFormatAsset,
VideoFormatGroupAsset,
Expand Down
35 changes: 35 additions & 0 deletions src/adcp/types/_eager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,23 @@
AcceptedLoss,
AcceptProposalRequest,
AcceptProposalResponse,
AccessibilityViolationDetails,
Account,
AccountAuthorization,
AccountMovedDetails,
AccountReference,
AccountScope,
AccountSetupRequiredDetails,
AccountWithAuthorization,
AcquireRightsRequest,
AcquireRightsResponse,
ActionNotAllowedDetails,
ActionNotAllowedReason,
ActivateSignalRequest,
ActivateSignalResponse,
AdcpProtocol,
AdvertiserIndustry,
AgentPermissionDeniedDetails,
AggregatedTotals,
AiTool,
Artifact,
Expand All @@ -67,13 +73,17 @@
AssignedPackage,
Assignments,
AudienceSource,
AudienceTooSmallDetails,
Authentication,
AuthenticationScheme,
AuthorizationRequiredDetails,
AuthorizedAgents,
AvailableMetric,
AvailablePackage,
BillingNotPermittedForAgentDetails,
BillingNotSupportedDetails,
BrandReference,
BudgetTooLowDetails,
BusinessEntity,
BuyingMode,
BuyProductsRequest,
Expand All @@ -99,6 +109,7 @@
CompatibilityPurchaseCoordinatorInput,
ComplyTestControllerRequest,
ComplyTestControllerResponse,
ConflictDetails,
Contact,
ContentIdType,
ContentStandards,
Expand Down Expand Up @@ -126,6 +137,7 @@
CreativeApprovalStatus,
CreativeAssignment,
CreativePolicy,
CreativeRejectedDetails,
CreativeStatus,
CreditLimit,
DaastTrackingEvent,
Expand Down Expand Up @@ -260,6 +272,7 @@
PlacementPresentationDocument,
PlacementPresentationReference,
PlacementReference,
PolicyViolationDetails,
PostalArea,
PreviewOutputFormat,
PreviewRender,
Expand Down Expand Up @@ -289,6 +302,7 @@
PushNotificationConfig,
QuartileData,
QuerySummary,
RateLimitedDetails,
ReachUnit,
ReferenceRenderer,
Refine,
Expand Down Expand Up @@ -348,6 +362,7 @@
Sort,
SortApplied,
SortDirection,
StaleResponseDetails,
StatusSummary,
SyncAccountsRequest,
SyncAccountsResponse,
Expand Down Expand Up @@ -394,6 +409,7 @@
VastTrackingEvent,
VastVersion,
VcpmPricingOption,
VendorErrorCodeRegistry,
VenueBreakdownItem,
VerifyBrandClaimPayload,
VerifyBrandClaimRequest,
Expand All @@ -408,6 +424,7 @@
VerifyBrandClaimsResponseBulk,
VerifyBrandClaimsSignedResponse,
VerifyBrandClaimsSignedSuccessPayload,
VersionUnsupportedDetails,
ViewThreshold,
WcagLevel,
WebhookChallenge,
Expand Down Expand Up @@ -1014,6 +1031,24 @@ def __init__(self, *args: object, **kwargs: object) -> None:
"RequestProposalsRequest",
"RequestProposalsResponse",
"UnsupportedRefinementDimensionDetails",
# Structured protocol error details
"AccessibilityViolationDetails",
"AccountMovedDetails",
"AccountSetupRequiredDetails",
"ActionNotAllowedDetails",
"ActionNotAllowedReason",
"AgentPermissionDeniedDetails",
"AudienceTooSmallDetails",
"BillingNotPermittedForAgentDetails",
"BillingNotSupportedDetails",
"BudgetTooLowDetails",
"ConflictDetails",
"CreativeRejectedDetails",
"PolicyViolationDetails",
"RateLimitedDetails",
"StaleResponseDetails",
"VendorErrorCodeRegistry",
"VersionUnsupportedDetails",
"A2UiComponent",
"A2UiSurface",
"Account",
Expand Down
17 changes: 17 additions & 0 deletions tests/fixtures/public_api_snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,14 +618,17 @@
"AcceptProposalRequest",
"AcceptProposalResponse",
"AcceptedLoss",
"AccessibilityViolationDetails",
"Account",
"AccountAuthorization",
"AccountIdReference",
"AccountMovedDetails",
"AccountReference",
"AccountReferenceById",
"AccountReferenceByNaturalKey",
"AccountResponse",
"AccountScope",
"AccountSetupRequiredDetails",
"AccountWithAuthorization",
"AcquireRightsAcquiredResponse",
"AcquireRightsErrorResponse",
Expand All @@ -635,6 +638,8 @@
"AcquireRightsResponse",
"AcquireRightsResponse1",
"Action",
"ActionNotAllowedDetails",
"ActionNotAllowedReason",
"ActivateSignalErrorResponse",
"ActivateSignalRequest",
"ActivateSignalResponse",
Expand All @@ -645,6 +650,7 @@
"AgentConfig",
"AgentDeployment",
"AgentDestination",
"AgentPermissionDeniedDetails",
"AggregatedTotals",
"AiTool",
"Artifact",
Expand All @@ -658,6 +664,7 @@
"AssignedPackage",
"Assignments",
"AudienceSource",
"AudienceTooSmallDetails",
"AudioContent",
"AudioFormatAsset",
"AudioFormatGroupAsset",
Expand All @@ -675,12 +682,15 @@
"AvailableMetric",
"AvailablePackage",
"AvailableReportingFrequency",
"BillingNotPermittedForAgentDetails",
"BillingNotSupportedDetails",
"BothPreviewRender",
"BrandIdentity",
"BrandReference",
"BrandSource",
"BriefAsset",
"BriefFormatAsset",
"BudgetTooLowDetails",
"BuildCreativeCreative",
"BusinessEntity",
"BusinessEntityResponse",
Expand Down Expand Up @@ -747,6 +757,7 @@
"ComplyTestControllerRequest",
"ComplyTestControllerResponse",
"ComplyTestControllerResponse1",
"ConflictDetails",
"ConsentBasis",
"Contact",
"ContentIdType",
Expand Down Expand Up @@ -798,6 +809,7 @@
"CreativeFilters",
"CreativeManifest",
"CreativePolicy",
"CreativeRejectedDetails",
"CreativeStatus",
"CreativeVariant",
"CreditLimit",
Expand Down Expand Up @@ -1109,6 +1121,7 @@
"PolicyHistory",
"PolicyRevision",
"PolicySummary",
"PolicyViolationDetails",
"PostalArea",
"PreviewOutputFormat",
"PreviewRender",
Expand Down Expand Up @@ -1169,6 +1182,7 @@
"PushNotificationConfig",
"QuartileData",
"QuerySummary",
"RateLimitedDetails",
"ReachUnit",
"RealEstateUnit",
"Recovery",
Expand Down Expand Up @@ -1250,6 +1264,7 @@
"SortApplied",
"SortDirection",
"Source",
"StaleResponseDetails",
"Status",
"StatusSummary",
"SyncAccountsAccount",
Expand Down Expand Up @@ -1375,6 +1390,7 @@
"VcpmFixedRatePricingOption",
"VcpmPricingOption",
"VehicleUnit",
"VendorErrorCodeRegistry",
"VendorPricingOptionUnion",
"VenueBreakdownItem",
"VerifyBrandClaimPayload",
Expand All @@ -1390,6 +1406,7 @@
"VerifyBrandClaimsResponseBulk",
"VerifyBrandClaimsSignedResponse",
"VerifyBrandClaimsSignedSuccessPayload",
"VersionUnsupportedDetails",
"VideoContent",
"VideoFormatAsset",
"VideoFormatGroupAsset",
Expand Down
Loading
Loading