fix(webhooks): validate outbox worker configuration - #1089
Merged
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean follow-up hardening on the PG task-webhook outbox.
What I checked:
- No critical/high findings (row 1 does not fire).
gated_paths: false— row 2 does not apply despitereview_decision: REVIEW_REQUIRED.high_risk: true, but the only reason issrc/adcp/decisioning/pg/task_webhook_outbox.py (modified)— a modification with zero medium-or-higher findings, so it is presumed safe (rows 3–5 require a deletion or a medium finding; none present).- No prior decision; no no-auto-approve team match (row 7 clear).
- Zero findings total, so row 8 (≥3 medium) does not fire.
The change rejects non-async / missing sender resolvers at construction (fail-closed, with inspect.unwrap for @wraps'd async methods), raises the lease_seconds floor to keep the delivery timeout budget positive, and documents the beta.9 fixed-to-resolver migration with a no-overlap rollout requirement. Both new reject branches plus the RFC 9421 sender path are tested. No public-surface, wire-shape, or type-layering impact. Falls through to row 9 → approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up hardening from the expert review of #1081 and merged PR #1085.
Validation
uv run pytest -q tests/test_task_webhook_outbox_pg.py tests/test_webhook_signing_capabilities.py tests/test_decisioning_dispatch.py(138 passed across final focused runs)make lintmake typecheck-all