fix: upgrade yeoman-environment to v6 to resolve 6 high-severity tar CVEs - #80
Merged
Merged
Conversation
Upgrades yeoman-environment from ^4.2.1 to ^6.1.0. The v4 dependency chain pulled in tar <=7.5.10 (via fly-import → @npmcli/arborist → cacache), which carried 6 high-severity CVEs. v6 resolves to tar 7.5.15 through an updated arborist/cacache chain, eliminating all findings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/review |
pru55e11
approved these changes
May 21, 2026
MichaelGoberling
approved these changes
May 21, 2026
Contributor
|
Thanks for the contribution @thedoc31! Going to merge this, and will look at doing a release shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
yeoman-environmentfrom^4.2.1to^6.1.0inpackage.json. This is a one-line dependency change that eliminates all 7 open vulnerability findings (6 high, 1 low) reported bynpm audit.Root cause
The v4 dependency chain pulled in
tar <=7.5.10through:tar@6.2.1carries 6 high-severity path traversal/symlink CVEs. The v6 chain resolves cleanly:CVEs resolved
C:../target.txt)diffparsePatch/applyPatchvia line break chars in filenamesAPI compatibility analysis
The three yeoman-environment methods used in
src/commands/templates/install.jswere verified by direct source inspection of both v4.4.3 and v6.1.0:createEnv()— identical export signature in both versionsenv.instantiate(constructor, { options: {...} })— present in both; the{ options: {...} }call form is handled by an explicit backward-compatibility branch in v6'sgetInstantiateOptions, identical logic to v4env.runGenerator(gen)— body is character-for-character identical in both versionsenv.optionsproperty assignment — plain writable property in both versionsOld-style generators (without
queueTasks()) run via thecompatibilityMode = 'v4'path in both versions, which is identical.Validation
npm auditafter upgrade: 0 vulnerabilities (was 17: 2 low, 15 high)NODE_OPTIONS=--experimental-vm-modules: 151/151 tests passing, 100% coverage across all filesnpm installresult: 46 packages added, 110 removed, 110 changed — consistent with the dependency chain swap