fix: bump archiver ^5->^7 and unzipper ^0.10->^0.12 to drop deprecated transitive deps (APPBLD-4609) - #932
Open
AnujVishwakarma-src wants to merge 2 commits into
Conversation
…d transitive deps (APPBLD-4609) archiver@5 pulls archiver-utils@2/3 -> glob@7 -> inflight@1.0.6 (deprecated, leaks memory); archiver@7 drops that chain (archiver@8 is ESM-only, so 7 is the CJS ceiling). unzipper@0.10 pulls fstream@1.0.12 (unsupported) -> rimraf@2.7.1 (deprecated); unzipper@0.12 removes both. Clean npm install deprecation warnings: 18 -> 16 (fstream@1.0.12 and rimraf@2.7.1 eliminated). Residual glob/inflight warnings are co-driven by other chains (transitive archiver@6 from @adobe/aio-lib-runtime, yeoman-generator@5, jest) and are addressed by their own tickets. Validation: unit tests introduce no new failures; lint clean; un-mocked round-trip smoke of the real pack.js (archiver) and install.js (unzipper Parse + Open.file/extract) code paths passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
archiver^5.3.1 → ^7.0.1unzipper^0.10.11 → ^0.12.5Both are the highest CommonJS-compatible targets (archiver@8 is ESM-only), keeping this a drop-in dependency cleanup with no source changes.
Why
These two direct deps pull deprecated transitive packages:
archiver@5→archiver-utils@2/3→glob@7→inflight@1.0.6(deprecated, "leaks memory"). archiver@7 drops this chain.unzipper@0.10→fstream@1.0.12(unsupported) →rimraf@2.7.1(deprecated). unzipper@0.12 removes both.Evidence — clean
npm installdeprecation warnings: 18 → 16Eliminated by this PR:
The remaining
glob@7/glob@8/inflightwarnings are co-driven by other dependency chains and are intentionally out of scope here:archiver@6from@adobe/aio-lib-runtime(addressed by fix: bump archiver ^6 -> ^7 to drop deprecated inflight (APPBLD-4614) aio-lib-runtime#234)yeoman-generator@5(via@adobe/generator-aio-app)jest@29(devDependency)So the archiver bump's benefit is partly masked until those land — but it is required so the eventual full cleanup resolves.
Validation
master— a pre-existing Node 26 +@oclif/coredynamic-import/Jest issue, unrelated to these deps).pack.jszipHelper(archiverdirectory/file/finalize) →install.jsvalidateZipDirectoryStructure(unzipper.Parse({forceStream})) →unzipFile(unzipper.Open.file().extract()), with content verified after extraction.Notes
Supersedes #915 (dependabot unzipper 0.10→0.12.3) — this PR takes unzipper to 0.12.5 and additionally bumps archiver.
🤖 Generated with Claude Code