Skip to content

feat(aem/cloud-service): add vault-package-dependencies code-assessme… - #300

Open
bharat941 wants to merge 1 commit into
adobe:mainfrom
bharat941:feat/vault-package-dependencies-pattern
Open

feat(aem/cloud-service): add vault-package-dependencies code-assessme…#300
bharat941 wants to merge 1 commit into
adobe:mainfrom
bharat941:feat/vault-package-dependencies-pattern

Conversation

@bharat941

Copy link
Copy Markdown
Contributor

…nt pattern

  • Add VaultPackageDependencies detector (pom-only, mechanical fix)
  • Add expert skill SKILL.md + recipe.md under code-assessment/
  • Register detector in Registry.java
  • Add routing hint to code-assessment/SKILL.md
  • Add catalog row (high severity, ready, analyzer, mechanical) to patterns.md
  • Add vault deploy blocker entry to migration/SKILL.md
  • Add positive + negative test fixtures
  • Add test cases to run-tests.sh
  • Remove duplicate standalone skills/vault-package-dependencies/ skill

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…nt pattern

- Add VaultPackageDependencies detector (pom-only, mechanical fix)
- Add expert skill SKILL.md + recipe.md under code-assessment/
- Register detector in Registry.java
- Add routing hint to code-assessment/SKILL.md
- Add catalog row (high severity, ready, analyzer, mechanical) to patterns.md
- Add vault deploy blocker entry to migration/SKILL.md
- Add positive + negative test fixtures
- Add test cases to run-tests.sh
- Remove duplicate standalone skills/vault-package-dependencies/ skill

@rombert rombert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bharat941 . The code overall looks good to me but I am missing a reference to the public Adobe documentation where the need to perform this step is specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants