Skip to content

Dark theme: others - #681

Merged
Rausterr merged 1 commit into
dark/corefrom
dark/others
Jun 6, 2026
Merged

Dark theme: others#681
Rausterr merged 1 commit into
dark/corefrom
dark/others

Conversation

@Marc-Andrieu

@Marc-Andrieu Marc-Andrieu commented May 8, 2026

Copy link
Copy Markdown
Member

Description

Summary

See #671

Non-comprehensive list of screenshots:

image image image

Required PRs

Depends on #671

Changes Made

  • others
    • tools/constants
    • loading_page
    • no_internet_page
    • no_module
    • update_page

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@Marc-Andrieu Marc-Andrieu self-assigned this May 8, 2026
@Marc-Andrieu Marc-Andrieu added enhancement New feature or request ready for review This PR is ready to be reviewed labels May 8, 2026
@codecov-commenter

codecov-commenter commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.87%. Comparing base (23ec27f) to head (2029419).

Additional details and impacted files
@@            Coverage Diff             @@
##           dark/core     #681   +/-   ##
==========================================
  Coverage      50.87%   50.87%           
==========================================
  Files            169      169           
  Lines           3819     3819           
==========================================
  Hits            1943     1943           
  Misses          1876     1876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu
Marc-Andrieu force-pushed the dark/others branch 3 times, most recently from 61e52a3 to 725f7ab Compare May 10, 2026 17:26

@Rausterr Rausterr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No internet 👍

@Rausterr Rausterr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@Rausterr
Rausterr merged commit 98470c7 into dark/core Jun 6, 2026
3 checks passed
@Rausterr
Rausterr deleted the dark/others branch June 6, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants