Skip to content

Dark theme: admin - #686

Merged
Rausterr merged 9 commits into
dark/corefrom
dark/admin
May 27, 2026
Merged

Dark theme: admin#686
Rausterr merged 9 commits into
dark/corefrom
dark/admin

Conversation

@Marc-Andrieu

@Marc-Andrieu Marc-Andrieu commented May 22, 2026

Copy link
Copy Markdown
Member

Description

Summary

See #671

Main

image

Permissions

image

Groups

image image image image

Schools: same UI as groups, see there

Structure (critical page so screenshots even when repetitive)

image image image image

Memberships (see also schools for similar pages)

image image

Required PRs

Depends on #671

Changes Made

(yes it's a big module nowadays...)

  • admin
    • components
      • admin_button
      • item_card_ui
      • text_editing
      • user_ui
    • pages
      • groups
        • add_group_page
        • add_loaner_page
        • edit_group_page
          • edit_group_page
          • results
          • search_user
        • groupe_page
          • group_button
          • group_page
          • group_ui
      • main_page
        • main_page
        • menu_card_ui
      • memberships
        • add_edit_user_membership_page
          • edd_edit_user_membership_page
          • search_result
        • association_membership_detail_page
          • association_membership_detail_page
          • association_membership_information_editor
          • association_membership_member_editable_card
          • research_bar
          • search_filters
        • association_membership_page
          • association_membership_page
          • association_membership_button
          • association_membership_creation_dialog
          • association_membership_page
          • association_membership_ui
      • permissions
        • module_expansion_panel
        • permission_expansion_panel
        • permission_row
        • permissions
      • schools
        • add_school_page
        • edit_school_page
        • school_page
          • school_button
          • school_page
          • school_ui
      • structure_page
        • add_edit_structure_page
          • add_edit_structure_page
          • results
          • search_user
        • structure_button
        • structure_page
        • structure_ui
    • admin

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@Marc-Andrieu Marc-Andrieu self-assigned this May 22, 2026
@Marc-Andrieu Marc-Andrieu added the enhancement New feature or request label May 22, 2026
@codecov-commenter

codecov-commenter commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.87%. Comparing base (23ec27f) to head (f6769e8).

Additional details and impacted files
@@            Coverage Diff             @@
##           dark/core     #686   +/-   ##
==========================================
  Coverage      50.87%   50.87%           
==========================================
  Files            169      169           
  Lines           3819     3819           
==========================================
  Hits            1943     1943           
  Misses          1876     1876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu
Marc-Andrieu marked this pull request as ready for review May 23, 2026 12:48
@Marc-Andrieu Marc-Andrieu added the ready for review This PR is ready to be reviewed label May 23, 2026

@Rausterr Rausterr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say

@PabloBellissant PabloBellissant left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do some widgets lost their const attribute ?

@Rausterr

Copy link
Copy Markdown

Why do some widgets lost their const attribute ?

no.

@Rausterr Rausterr closed this May 26, 2026
@Rausterr Rausterr reopened this May 26, 2026
@Rausterr
Rausterr merged commit aee52a6 into dark/core May 27, 2026
8 checks passed
@Rausterr
Rausterr deleted the dark/admin branch May 27, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants