Skip to content

Dark theme: Centralassociation - #689

Merged
NakoGH merged 2 commits into
dark/corefrom
dark/centralassociation
Jun 1, 2026
Merged

Dark theme: Centralassociation#689
NakoGH merged 2 commits into
dark/corefrom
dark/centralassociation

Conversation

@Rausterr

@Rausterr Rausterr commented May 27, 2026

Copy link
Copy Markdown

Description

Summary

See #671

image

Required PRs

Depends on #671

Changes Made

Dark mode on the Centrassociation module

  • centralassociation
    • pages
      • link_card
      • main_page
      • asso_list
    • centralassociation

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@codecov-commenter

codecov-commenter commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.61%. Comparing base (596c459) to head (65133e9).

Additional details and impacted files
@@            Coverage Diff             @@
##           dark/core     #689   +/-   ##
==========================================
  Coverage      50.61%   50.61%           
==========================================
  Files            169      169           
  Lines           3839     3839           
==========================================
  Hits            1943     1943           
  Misses          1896     1896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rausterr Rausterr added enhancement New feature or request ready for review This PR is ready to be reviewed labels May 27, 2026

@Marc-Andrieu Marc-Andrieu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Make sure it's consistent with Centralisation (maybe you changed the color of the shadow of the box behind icons)

Comment thread lib/centralassociation/ui/pages/asso_list.dart
@NakoGH
NakoGH force-pushed the dark/centralassociation branch from 8187594 to 65133e9 Compare June 1, 2026 10:52
@NakoGH
NakoGH merged commit 423289f into dark/core Jun 1, 2026
3 checks passed
@NakoGH
NakoGH deleted the dark/centralassociation branch June 1, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants