Bump gwt-client-common to pick up vue-gwt scoped-CSS fix - #84
Merged
Merged
Conversation
search-client pinned gwt-client-common 1.9.0, which predates the vue-gwt fork fix that moved scoped-CSS injection into the shared factory init() method. Since search-client's Vue components are constructed via Gin/DI (not the static get() accessor), their scoped CSS was never injected - search results render unstyled. gwt-client-common 1.12.0-SNAPSHOT is the same version calculator currently points at to get this fix (not yet in a stable release).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM-generated technical summary
search-client pinned gwt-client-common 1.9.0, which predates the vue-gwt fork fix
(aerius/vue-gwt#9) that moved scoped-CSS injection out of the generated factory's
static get() accessor and into the shared init() method. search-client's Vue
components are wired into consuming apps via Gin/DI, which calls init() directly
and never touches get() - so their scoped CSS was never injected, and search
results rendered unstyled. 1.12.0-SNAPSHOT is the same not-yet-released version
calculator already points at to get this fix; this pin should move to a stable
release once gwt-client-common's own version bump (aerius/gwt-client-common#79)
ships.