Skip to content

Fixed the performance metric reporting the queue names were swapped. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hilbrand merged 1 commit into from
Sep 11, 2026
Merged

Fixed the performance metric reporting the queue names were swapped. #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ...e/taskmanager/src/main/java/nl/aerius/taskmanager/metrics/PerformanceMetricsReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,28 +143,28 @@ private DurationMetric createQueueDurationMetric(final TaskMetrics taskMetrics)

private synchronized void update() {
try {
metrics(DISPATCH, dispatchedQueueMetrics, dispatchedWorkerCountGauge, dispatchedWorkerWaitGauge);
metrics(DISPATCH, dispatchedQueueCountGauge, dispatchedQueueWaitGauge, queueGroupName, dispatchedWorkerMetrics);
metrics(WORK, workQueueMetrics, workWorkerCountGauge, workWorkerDurationGauge);
metrics(WORK, workQueueCountGauge, workQueueDurationGauge, queueGroupName, workWorkerMetrics);
metrics(DISPATCH, dispatchedWorkerCountGauge, dispatchedWorkerWaitGauge, queueGroupName, dispatchedWorkerMetrics);
metrics(DISPATCH, dispatchedQueueCountGauge, dispatchedQueueWaitGauge, dispatchedQueueMetrics);
metrics(WORK, workWorkerCountGauge, workWorkerDurationGauge, queueGroupName, workWorkerMetrics);
metrics(WORK, workQueueCountGauge, workQueueDurationGauge, workQueueMetrics);
} catch (final RuntimeException e) {
LOG.error("Update metrics failed.", e);
}
}

private static void metrics(final String prefixText, final Map<String, DurationMetric> metrics, final DoubleGauge gauge,
final DoubleGauge waitGauge) {
private static void metrics(final String prefixText, final DoubleGauge countGauge, final DoubleGauge waitGauge,
final Map<String, DurationMetric> metrics) {
for (final Entry<String, DurationMetric> entry : metrics.entrySet()) {
metrics(prefixText, gauge, waitGauge, entry.getKey(), entry.getValue());
metrics(prefixText, countGauge, waitGauge, entry.getKey(), entry.getValue());
}
}

private static void metrics(final String prefixText, final DoubleGauge gauge, final DoubleGauge averageGauge, final String name,
private static void metrics(final String prefixText, final DoubleGauge countGauge, final DoubleGauge averageGauge, final String name,
final DurationMetric metrics) {
final DurationMetricValue metric = metrics.process();
final int count = metric.count();

gauge.set(count, metrics.getAttributes());
countGauge.set(count, metrics.getAttributes());
averageGauge.set(metric.avgDuration(), metrics.getAttributes());
if (count > 0) {
LOG.debug("{} for {}: {} ms/task (#tasks: {})", prefixText, name, metric.avgDuration(), count);
Expand Down
Loading