feat: [CLIENT-5161] add reusable workflow to promote release bundles - #284
Open
juliannguyen4 wants to merge 14 commits into
Open
feat: [CLIENT-5161] add reusable workflow to promote release bundles#284juliannguyen4 wants to merge 14 commits into
juliannguyen4 wants to merge 14 commits into
Conversation
…ote bundles to STAGE
…e after creating it
…he bundle after creating it" This reverts commit 43cfc65.
juliannguyen4
changed the title
… testing this anyways. There doesn't seem to be an e2e test for the composable workflow approach
…ticed there's other code examples that use tags instead of sha, which isn't good practice...
juliannguyen4
marked this pull request as ready for review
July 29, 2026 14:33
atripathi-aerospike
approved these changes
Jul 29, 2026
arrowplum
reviewed
Aug 7, 2026
| oidc-provider-name: ${{ inputs.oidc-provider-name }} | ||
| oidc-audience: ${{ inputs.oidc-audience }} | ||
|
|
||
| - uses: ./.github/actions/promote-release-bundle |
Contributor
There was a problem hiding this comment.
This workflow just wraps the action but doesn't add anything extra like validation or ensuring stages aren't skipped.
arrowplum
requested changes
Aug 7, 2026
Contributor
There was a problem hiding this comment.
This is lacking a reason to exist other than a desire to use actions instead of workflows. I can see a place for it but only if it also adds the extra protections: Making sure it doesn't jump any stages in a promotion, making sure it satisfies any criteria, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows developers to promote their release bundles to DEV and TEST, as well as QE to promote release bundles from TEST to STAGE.
Test plan
Python client can reuse this workflow too, but it needs to tag the release bundle in a different job nowJust sticking to my own vendored copy of the workflowTODO