fix(deploy): [INFRA-673] guard sibling-POM metadata against inherited fields - #288
Closed
arrowplum wants to merge 1 commit into
Closed
fix(deploy): [INFRA-673] guard sibling-POM metadata against inherited fields#288arrowplum wants to merge 1 commit into
arrowplum wants to merge 1 commit into
Conversation
alexs-aero
previously approved these changes
Aug 7, 2026
Base automatically changed from
fix/INFRA-670-artifacts-cicd-actions-permission
to
main
August 7, 2026 16:50
- A POM inheriting fields from <parent> resolved empty and clobbered good values. - Adds a regression test; it fails without the guard. - The test sets -e locally because setup() disables errexit, making bare assertions inert.
arrowplum
force-pushed
the
fix/INFRA-673-jar-metadata-inherited-pom
branch
from
August 7, 2026 17:00
4600934 to
d833abb
Compare
arrowplum
marked this pull request as draft
August 11, 2026 18:43
Contributor
Author
|
I distrust the changes I made here https://github.com/aerospike/shared-workflows/pull/288/changes#diff-bf06e3077646d14359ffbdb572db33ac4049f3108af3c8857864a1f5baf87b69 since I was copying the code above outside of the loop. @alexs-aero That is why I assigned the ticket over to you. |
alexs-aero
self-requested a review
August 11, 2026 20:10
Contributor
|
Superseded by #293 . That branch extracts _maven_read_pom_coordinates (parent fallbacks + shared with type_detection.sh / entrypoint.sh), adopts the non-empty guard from this PR, and adds full GAV test coverage. Keeping only the guard here leaves inherited child modules uploading without groupId. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_jar_metadatareads a sibling POM when a JAR has nopom.propertiesinside it. It readsartifactId,versionandgroupIdas direct children of<project>, so a POM that inherits any of them from<parent>resolves to an empty string and overwrites the value already derived from the filename. A child module JAR in a flat layout then structures and uploads with an empty version or package name.Inheriting
groupIdandversionfrom a parent is the normal multi-module shape, so this hits any flat layout. Each field is now assigned only when the POM actually supplies it.INFRA-673
Guards the sibling-POM branch added by #287, now merged.
Test plan: the new inherited-POM test fails without the guard and passes with it.