Revert premature channel skill service suggestions - #3685
Merged
AbigailDeng merged 1 commit intoSep 29, 2026
Merged
AbigailDeng merged 1 commit into
AbigailDeng merged 1 commit into
Conversation
AbigailDeng
merged commit Sep 29, 2026
4eb3b8c
into
feat/2026-08-04_workflow-activity-vnext
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Skill service recommendation panel introduced by #3679 from both Channel Bind and Edit. The frontend reached production before backend #3683 was merged/deployed, so selecting a Skill displayed a recommendation failure. This is the user-requested partial revert of merge commit 9842ab8.
The Suggested for panel, Refresh suggestions button, discovery failure copy, Manage connections in NyxID link and
/api/skills/service-recommendationsrequests are removed, together with their unused adapter, query key, styles and translations. Preserve active account service selection (including services omitted at login), required built-in services, explicit Bind/Save and observed completion. The backend PR remains separate. Documentation records the withdrawal and requires explicit approval plus deployed backend verification before any future reintroduction.Local verification
Passed: 8 related suites / 44 tests; Biome for all 8 remaining changed source/test files; test stability guards and diff whitespace checks.
Dependency discovery selected seven route suites. Run the six Channel suites; the broad vNext index suite also covers unrelated workflow/settings behavior, which is delegated to CI. Also run the directly affected locale catalog and the service inventory adapter tests. Existing Bind and Edit scenarios now assert that selected Skills render no recommendation panel/link/action and make no recommendation request.
Full frontend suite, typecheck and production build are delegated to GitHub CI by personal local workflow policy. No reliable repository-native affected typecheck is available.
Design baseline
apps/aevatar-console-web/docs/design-baselines/workflow-activity-vnext/aevatar-workflow-activity-vnext.excalidraw30e74d7b410ae72c4c91432355436679033679c54c10b1702908435b001577deapps/aevatar-console-web/docs/superpowers/specs/2026-08-04-workflow-activity-vnext-design.mdapps/aevatar-console-web/docs/superpowers/specs/2026-08-04-workflow-activity-vnext-user-paths.md