Fix exec/focuswindow/splitratio dispatch calls for Hyprland's lua syntax - #5
Open
AndresSM415 wants to merge 1 commit into
Open
AndresSM415 wants to merge 1 commit into
AndresSM415 wants to merge 1 commit into
Conversation
hyprland-rs 0.4.0-beta.3's Dispatch:call() predates Hyprland's dispatch syntax change (see hyprwm/Hyprland#14675). Bypass it and shell out to hyprctl dispatch directly with the corrected h1.dsp.* lua calls instead. Fixes agata#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
See the root-cause writeup in my comment on #4 — hyprland-rs 0.4.0-beta.3 predates a Hyprland dispatch syntax change. This bypasses `Dispatch::call()` and shells out to `hyprctl dispatch` with the corrected `hl.dsp.*` calls for the three affected sites.
Tested end-to-end on Hyprland 0.56.2 — multi-slot worksets with splits and ratio adjustments launch cleanly with no errors or warnings.
Note: cargo clippy currently fails on main in ui/home/events.rs, unrelated to this change (confirmed by stashing this diff and re-running) — left untouched to keep this PR scoped to the actual fix.