feat: train v2 - release direct to master - #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Friday minor-release train off the release-PR delivery pattern (branch -> PR -> auto-merge -> approve/poll) to direct-to-master ("v2-lite"). This broke 3 different ways in 3 weeks across the estate; the side-project trains that already push directly to master went 6/6 green.
Unchanged: cron slot, workflow_dispatch (no inputs), dependabot-quiescence wait, releasable-commit detection logic, minor-only bump (package.json + manifest.json + versions.json via
npm version --no-git-tag-version minor), verify step, and the final dispatch ofrelease.ymlwithbuild_current=true(same as before - release.yml itself tags the version already on master's manifest.json in build-current mode).Replaced:
release/<version>branch + PR create + auto-merge ->git pull --rebase origin master+git commit+git push origin HEAD:master(push failure is red, never forced). No tagging happens in train.yml here - that stays insiderelease.yml's build-current path, unchanged.Added (fail-closed completion): the dispatched
release.ymlrun is now polled to conclusion viagh run watch --exit-status, and the published GitHub release is asserted afterward (tag == manifest version, assets = main.js/manifest.json/styles.css present). Previously the train job went green the moment it dispatched release.yml, with no verification the publish actually succeeded.The now-dead "skip if an open release PR exists" guard step is deleted.
Do NOT merge - draft for review. Do NOT dispatch the train from this PR.
Test plan
python3 -c "import yaml; yaml.safe_load(...)"- YAML parses clean (no actionlint available locally)ci.yml/lint checks)