fix: name a deployment row's cadence as it runs, and capitalize the grant refusal - #2553
Merged
Merged
Conversation
…rant refusal The agent page named every GitHub row's cadence with the thread words, so a deployment row and a release row both read "Opened". It now reads "Created" / "Any status" for a deployment and "Published" for a release, the words the Add integration tiles already use. Revoking an installation grant that installation-wide triggers still use now answers "Delete the triggers ..." instead of starting lowercase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zfy0701
enabled auto-merge (squash)
September 26, 2026 20:19
Contributor
There was a problem hiding this comment.
Approved. The agent page now uses deployment and release cadence names at rest and in the trigger menu, while thread rows keep their existing wording. The grant-revocation 409 message is capitalized. I found no blocking issue in the changed paths. git diff --check passed; I could not run the focused web tests in this checkout because pnpm is unavailable and node_modules is absent.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2398. There are two wording slips on the agent page. The installation-wide trigger test on the test environment surfaced both.
Cadence names. A GitHub deployment row's trigger read "Opened", and so did a release row's, because the agent page names every row with the thread cadences (
GH_TRIGGER_PILL). The row and its menu now read:These are the words the Add integration tiles already use. Thread rows are unchanged.
The grant revocation refusal. Revoking an installation grant that installation-wide triggers still use returned a 409 message that started lowercase ("delete the triggers …"). It now starts "Delete the triggers …".
Changes
github-events.ts:githubTriggerPill(mode, family), used by the agent page's resting label and trigger menu in place ofGH_TRIGGER_PILL[mode].agent-repos.ts: the 409 message is capitalized, and its route test now matches the whole message.Tests
github-events.test.ts: the pill words for deployment, release, a thread family and no family.AgentDetailView.codehost.test.tsx:--maxWorkers=2: 315 files, 3350 tests passed.pnpm --filter @agentconnect.md/web typecheckpasses.agent-repos.route.test.ts: 53 passed.🤖 Generated with Claude Code . Opus 5.5