Skip to content

fix: name a deployment row's cadence as it runs, and capitalize the grant refusal - #2553

Merged
zfy0701 merged 1 commit into
mainfrom
claude/trigger-wording
Sep 26, 2026
Merged

zfy0701 merged 1 commit into
mainfrom
claude/trigger-wording

Conversation

@zfy0701

@zfy0701 zfy0701 commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Part of #2398. There are two wording slips on the agent page. The installation-wide trigger test on the test environment surfaced both.

  • Cadence names. A GitHub deployment row's trigger read "Opened", and so did a release row's, because the agent page names every row with the thread cadences (GH_TRIGGER_PILL). The row and its menu now read:

    • "Created" and "Any status" for a deployment;
    • "Published" for a release.

    These are the words the Add integration tiles already use. Thread rows are unchanged.

  • The grant revocation refusal. Revoking an installation grant that installation-wide triggers still use returned a 409 message that started lowercase ("delete the triggers …"). It now starts "Delete the triggers …".

Changes

  • github-events.ts: githubTriggerPill(mode, family), used by the agent page's resting label and trigger menu in place of GH_TRIGGER_PILL[mode].
  • agent-repos.ts: the 409 message is capitalized, and its route test now matches the whole message.

Tests

  • github-events.test.ts: the pill words for deployment, release, a thread family and no family.
  • AgentDetailView.codehost.test.tsx:
    • A deployment row reads "Created" and its menu offers "Created" and "Any status".
    • No span on the page reads "Opened". Both responsive trees render in the test, so this also covers the mobile resting label.
    • Passing no family at either call site turns this case red.
  • Web suite, --maxWorkers=2: 315 files, 3350 tests passed. pnpm --filter @agentconnect.md/web typecheck passes.
  • agent-repos.route.test.ts: 53 passed.

🤖 Generated with Claude Code . Opus 5.5

…rant refusal

The agent page named every GitHub row's cadence with the thread words, so a
deployment row and a release row both read "Opened". It now reads "Created" /
"Any status" for a deployment and "Published" for a release, the words the
Add integration tiles already use. Revoking an installation grant that
installation-wide triggers still use now answers "Delete the triggers ..."
instead of starting lowercase.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zfy0701
zfy0701 enabled auto-merge (squash) September 26, 2026 20:19

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The agent page now uses deployment and release cadence names at rest and in the trigger menu, while thread rows keep their existing wording. The grant-revocation 409 message is capitalized. I found no blocking issue in the changed paths. git diff --check passed; I could not run the focused web tests in this checkout because pnpm is unavailable and node_modules is absent.

sent by review-bot (Codex · gpt-6-sol) · open in session

@zfy0701
zfy0701 merged commit 52134a0 into main Sep 26, 2026
13 checks passed
@zfy0701
zfy0701 deleted the claude/trigger-wording branch September 26, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant