Skip to content

fix(control-plane): find an installation row's sessions under their repository - #2556

Merged
zfy0701 merged 1 commit into
mainfrom
claude/installation-session-filter
Sep 26, 2026
Merged

zfy0701 merged 1 commit into
mainfrom
claude/installation-session-filter

Conversation

@zfy0701

@zfy0701 zfy0701 commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Part of #2398. This closes one of the known gaps #2530 listed.

  • The gap. The sessions list's repository filter (githubRepoId) keeps sessions whose trigger is a GitHub row of that repository. An installation-wide row has no repository, so none of its sessions appeared under any repository.
  • The fix. Such a session carries the event's repository in its channel, github:<repoId>: the relay keys installation threads that way, and new repository rows use the same prefix. The filter now also keeps the sessions an installation row triggered on that channel.

Changes

  • sessions.ts: codeHostHookFilters also returns, for a githubRepoId filter, the organization's installation-row hook ids and the repository's github:<id> channel. Both the facets and list handlers pass it on.
  • ports.ts / session.repo.ts:
    • hookTriggerInstallationChannel ORs "triggered by one of these installation rows, on this channel" into the repository filter.
    • The trigger facet drops it together with hookTriggerIds, as it already does for the repository arm.

Unchanged. The web needs no change. An installation row's trigger still shows as its own filter option (<account>/*), and selecting it still lists every repository it ran on.

Tests

  • New sessions.history.route.test.ts case:
    • It uses a repository row, an installation row on github:123, and the same installation row on github:456.
    • githubRepoId=123 returns the repository row's session and the installation row's github:123 session, total 2.
    • The installation row's own trigger filter still returns both of its sessions.
  • Mutation checks, each turning the case red:
    • dropping the installation arm;
    • dropping its channel condition;
    • not passing it from the list handler.
  • The 9 session integration and repository files: 169 passed.
  • test:unit: 230 files, 2833 tests passed.
  • pnpm --filter @agentconnect.md/control-plane typecheck passes.

🤖 Generated with Claude Code . Opus 5.5

…epository

The session list's repository filter kept sessions whose trigger is a GitHub
row of that repository, and an installation-wide row has no repository, so
none of its sessions showed under any repository. Such a session carries the
event's repository in its channel (`github:<repoId>`), so the filter now also
keeps sessions an installation row triggered on that channel. The
installation's own trigger filter still lists every repository it ran on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zfy0701
zfy0701 enabled auto-merge (squash) September 26, 2026 20:34

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The repository filter now includes installation-row sessions on the selected github:<repoId> channel, and the list and facets use the same predicate. The trigger facet still drops the repository filter as intended. I found no blocking regression in the verified merge. I reviewed the code paths; I could not rerun the Postgres integration test locally because Docker is unavailable.

sent by review-bot (Codex · gpt-6-sol) · open in session

@zfy0701
zfy0701 merged commit fc5f45a into main Sep 26, 2026
13 checks passed
@zfy0701
zfy0701 deleted the claude/installation-session-filter branch September 26, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant