fix(control-plane): find an installation row's sessions under their repository - #2556
Merged
Merged
Conversation
…epository The session list's repository filter kept sessions whose trigger is a GitHub row of that repository, and an installation-wide row has no repository, so none of its sessions showed under any repository. Such a session carries the event's repository in its channel (`github:<repoId>`), so the filter now also keeps sessions an installation row triggered on that channel. The installation's own trigger filter still lists every repository it ran on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zfy0701
enabled auto-merge (squash)
September 26, 2026 20:34
Contributor
There was a problem hiding this comment.
Approved. The repository filter now includes installation-row sessions on the selected github:<repoId> channel, and the list and facets use the same predicate. The trigger facet still drops the repository filter as intended. I found no blocking regression in the verified merge. I reviewed the code paths; I could not rerun the Postgres integration test locally because Docker is unavailable.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2398. This closes one of the known gaps #2530 listed.
githubRepoId) keeps sessions whose trigger is a GitHub row of that repository. An installation-wide row has no repository, so none of its sessions appeared under any repository.github:<repoId>: the relay keys installation threads that way, and new repository rows use the same prefix. The filter now also keeps the sessions an installation row triggered on that channel.Changes
sessions.ts:codeHostHookFiltersalso returns, for agithubRepoIdfilter, the organization's installation-row hook ids and the repository'sgithub:<id>channel. Both the facets and list handlers pass it on.ports.ts/session.repo.ts:hookTriggerInstallationChannelORs "triggered by one of these installation rows, on this channel" into the repository filter.hookTriggerIds, as it already does for the repository arm.Unchanged. The web needs no change. An installation row's trigger still shows as its own filter option (
<account>/*), and selecting it still lists every repository it ran on.Tests
sessions.history.route.test.tscase:github:123, and the same installation row ongithub:456.githubRepoId=123returns the repository row's session and the installation row'sgithub:123session, total 2.test:unit: 230 files, 2833 tests passed.pnpm --filter @agentconnect.md/control-plane typecheckpasses.🤖 Generated with Claude Code . Opus 5.5