docs(designs): say an installation row's repository list cannot be managed without a repository row - #2558
Merged
Conversation
…naged without a repository row #2557 said a repository covered by installation rows alone has no trusted users. That is not quite true: the list belongs to the repository, not to a row, and deleting a repository row leaves its entries, which an installation row then still reads. Say instead that without a repository row the list cannot be managed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zfy0701
enabled auto-merge (squash)
September 26, 2026 20:48
![agentconnect-md-test[bot]](https://avatars.githubusercontent.com/in/4157507?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved. The revised Trusted Users paragraph matches the implementation: entries are keyed to the repository, installation-wide triggers read that repository’s list, and removing a repository hook does not remove its entries. The repository hook is the available management path. This documentation-only change has no blocking issues.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows up a review note on #2557 (merged). The design's Trusted Users section said a repository covered by installation rows alone "has none". That is not quite true:
CodeHostTrustedActoris keyed by the repository id and has no reference to a hook;The paragraph now says that without a repository row the list cannot be managed, and that entries a removed repository row left still apply.
Changes
webhook-triggers-and-github-events.md, Trusted Users: the installation-row sentence is reworded. There is no behavior change.🤖 Generated with Claude Code . Opus 5.5