Skip to content

feat(web): merge a Decision's places and recent evaluations into one card - #2561

Merged
zfy0701 merged 2 commits into
mainfrom
claude/decision-usage-evaluations-card
Sep 27, 2026
Merged

zfy0701 merged 2 commits into
mainfrom
claude/decision-usage-evaluations-card

Conversation

@zfy0701

@zfy0701 zfy0701 commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Summary

The Decision page showed its places of use twice: once in a Used by card, and again as source buttons above a Recent evaluations list whose rows carried only a time, an answer, and an outcome. This merges them into one card and gives each row the evaluation title added in #2552.

  • One card, a tab per place. The header reads "Recent evaluations · used in N places". All merges every recorded place's latest page (10 each) by time; each place tab shows its row count (10+ when more exist). Places that record nothing (agent tools) still get a tab, which says so when selected.
  • Used by moves into the tabs. Hovering a tab shows the place's full name and kind (plus a gate's needs-review state) through the console's shared tooltip; a needs-review gate also carries a dot. Selecting a place puts Settings (the link the Used by name used to be) and Open panel (that source's drawer) in the header. Places the viewer cannot see are counted at the bottom, and an unused Decision says so.
  • Rows: title, then time · place (· channel for shared-bot rows) on the left; answer, then outcome · latency on the right. A row without an answer shows its outcome as a badge. Each line wraps its right side below instead of using columns, because the editor's left column is only 220–500px wide between 769px and roughly 1100px windows.
  • Agent model editor: the collapsible Recent evaluations under Try a sample is removed; it repeated the Decision page's list for that Agent's place. The hover card's drawer is unchanged.
  • Docs: decisions.md §9.5, the Decision deletion note, and code-host-decisions.md describe the places card instead of Used by.

Testing

  • DecisionRecentEvaluations: All reads every recorded place by its chain root and orders rows newest first with titles and channel names; selecting a place shows its chain note, settings link, and drawer; a non-recording place, a needs-review local gate, and hidden places; the unused state
  • DecisionEditorView: each place's Settings link goes where the Used by link went
  • The model-selection list test now drives the drawer, which shares the removed section's body
  • web typecheck, lint, and the Decision and Agent view suites
  • Checked in the mock console at 1440px, 900px (a 222px card), and 375px: no overlap and no horizontal scroll; the drawer opens from Open panel

🤖 Generated with Claude Code . Claude Opus 5.5

…card

The Decision page listed its places of use in a Used by card and then
repeated them as source buttons above a Recent evaluations list whose
rows showed only a time, an answer, and an outcome. One card now carries
both: a tab per place after an All tab that merges every recorded
place's latest page by time, each row led by the evaluation's title with
its time, place, outcome, and latency beneath. Hovering a tab names the
place's kind and a gate's review state through the console tooltip; a
selected place offers its settings and its full list in a drawer, and
places the viewer cannot see are counted below. Rows keep two lines that
wrap rather than columns, so the card reads the same in the editor's
narrow column and on a phone.

The Agent's By decision model editor drops its own Recent evaluations
section, which repeated the Decision page's list for that Agent's place;
the hover card's drawer stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The combined card keeps each recorded place's access-scoped read and source-specific detail drawer, and the new tab and row behavior matches the intended flow.

Non-blocking: outcome labels are translated inside the SWR fetcher, but the cache key does not include the locale. After switching the console language on this page, cached evaluation outcomes can remain in the previous language until SWR revalidates. Translating outcomes when rendering rows, or including the locale in the key, would keep them current.

I could not run the focused web tests or typecheck in this checkout because pnpm and node_modules are absent.

sent by review-bot (Codex · gpt-6-sol) · open in session

The places card cached each row's outcome already translated under a key
without the locale, so switching the console language could leave loaded
rows in the old language. Rows now keep the raw outcome and the card
words it per history when it renders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@agentconnect-md-test agentconnect-md-test Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at c2f78bc. This revision keeps raw outcome values in the SWR result and translates them when each row renders, so a console language change rewords already-loaded gate, routing, and model-selection outcomes. I found no blocking issue in the updated diff. I could not run the focused web checks in this checkout because pnpm and node_modules are absent.

sent by review-bot (Codex · gpt-6-sol) · open in session

@zfy0701
zfy0701 enabled auto-merge (squash) September 27, 2026 00:12
@zfy0701
zfy0701 merged commit c125fdb into main Sep 27, 2026
13 checks passed
@zfy0701
zfy0701 deleted the claude/decision-usage-evaluations-card branch September 27, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant