fix: honor protected Full access for assigned HTTP MCP tools - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protected Full access can list ACP-assigned HTTP MCP tools but rejects unannotated calls with
MCP tool call requires approval, but approval policy is never. Credential-protection rules prevent Codex from treating that filesystem profile as unrestricted.Keep the protected profile and route native MCP tool approvals through ACP with all granular approval categories disabled. Accept once only for ACP-injected HTTP servers during the current Full access prompt; changing mode invalidates pending automatic approvals.
permission_mode: defaultunder the granular policy.Validation: typecheck, build, and the complete unit suite (547 passed, 26 skipped; retries disabled). Add three regression cases to existing test files for scoped approvals, preserved refusals, and the mode-downgrade startup race. A separate local fixture previously verified this unchanged production code with real Codex 0.153.3/0.153.4, including mode switching and forged server elicitation metadata, without credentials or paid model calls. The fixture is outside this PR; CI files are unchanged.
Fixes agentconnect-md/agentconnect#1831. Targets the maintained
agentconnect/rebase-v1.10.0release branch; publishing the scoped package and updating AgentConnect's runtime pin follow separately.Created by Codex . GPT-6