bench: land cost-quality baseline with reliable result capture - #601
bench: land cost-quality baseline with reliable result capture#601jamestexas wants to merge 2 commits into
Conversation
Rescues benchmarks/cost-quality/ from the orphaned origin/feat/cost- quality-bench branch (no PR was ever opened for it) — mache-9077ae's own description cites run_20260513.jsonl and RESULTS.md by exact filename as "the first cost-quality bench... post-mortem in RESULTS.md", the baseline the bead's proper re-run builds on. Those files existed only on the orphan branch; landing them here so the citation resolves and the branch can be deleted without losing the referenced evidence. No code changes — self-contained benchmarks/cost-quality/ directory only. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KVGdDfjnYGWKYt7oLqPwWg
There was a problem hiding this comment.
Pull request overview
This PR restores the benchmarks/cost-quality/ benchmark harness and its first historical run artifacts (JSONL + post-mortem) from an orphaned branch, so a future “proper rerun” has an in-repo baseline to build on.
Changes:
- Adds the cost+quality benchmark runner (
bench.py) plus inputs (prompts.json,mcp.json) and usage docs (README.md). - Checks in the first captured run output (
results/run_20260513.jsonl) and a write-up explaining why the numbers shouldn’t be used yet (RESULTS.md). - Updates
.beads/beads.jsonlwith the latest bead record formache-7555da.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| benchmarks/cost-quality/results/run_20260513.jsonl | Archived JSONL output from the first benchmark run (baseline artifact). |
| benchmarks/cost-quality/RESULTS.md | Post-mortem describing why the run isn’t a meaningful mache evaluation yet. |
| benchmarks/cost-quality/README.md | How to run the benchmark and interpret outputs; documents provenance/attribution. |
| benchmarks/cost-quality/prompts.json | Prompt battery used by the benchmark runner. |
| benchmarks/cost-quality/mcp.json | MCP server config template used by claude in “mache” mode. |
| benchmarks/cost-quality/bench.py | Benchmark runner + heuristic quality scorer (resume-safe JSONL streaming). |
| .beads/beads.jsonl | Updates bead record(s) (notably mache-7555da) to the latest state/comments. |
Suppressed comments (1)
benchmarks/cost-quality/bench.py:108
- If
parse_claude_jsonreturns{},run_claudecurrently proceeds as if it succeeded and writes a row with zero tokens/cost and empty response. This makes format regressions in theclaudeCLI look like valid (but empty) benchmark results rather than hard failures.
data = parse_claude_json(result.stdout)
usage = data.get("usage", {})
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| import importlib.util | ||
| import subprocess | ||
| import unittest |
|
Leaving this as a draft, but flagging a landmine before it ever gets merged: the branch carries Same defect just closed #609 (that one had only the stale export, so there was nothing to save; this one has 826 lines of real benchmark harness worth keeping). Suggested fix when this comes off draft: drop Not touching the branch since it's yours and still draft. |
What changed
benchmarks/cost-quality/harness, prompt corpus, archived first run, and candid results post-mortemerrorearly as failed answersduplicate_definitionsandfan_out_skewwithout expanding the smell baselineValidation
python3 -m unittest discover -s benchmarks/cost-quality -vtask smellswith the fixed local LLO 0.18.1 binarytask ciin the normal pinned-Leyline environment, including race tests andinstall:verifyThe archived results remain a historical baseline, not a claim that the first run is decision-grade;
RESULTS.mddocuments those limitations.