fix(hosted): accept expiresAt in browser run responses - #194
Open
rishabhraj36 wants to merge 1 commit into
Open
Conversation
Contributor
🟢 No documentation gap found — medium confidenceThe automated review found no documentation gap in the supplied changes. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the hosted browser response contract and runtime validation to accept the optional
run.expiresAttimestamp returned by Webcmd Cloud.Previously, the strict response validator rejected otherwise-valid cloud responses containing this field, causing hosted browser commands and cloud-backed evals to fail with an invalid browser run response error.
Adds regression coverage to ensure:
expiresAtfields are accepted.expiresAtremain supported.expiresAtvalues are rejected.Related issue: Closes #193
Type of Change
Checklist
Adapter Notes
Not applicable—this change does not modify a site adapter or command interface.
CliErrorsubclasses instead of rawErrorScreenshots / Output
Before: