Implmemnted Feature Windows Gameserver Move Alpha to beta by Sivasankaran25 · Pull Request #4560 · agones-dev/agones

Sivasankaran25 · 2026-05-11T09:01:05Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4523

Special notes for your reviewer:

agones-bot · 2026-05-11T09:18:18Z

Build Failed 😭

Build Id: 1d89798a-9fcf-422e-a2a2-c65b60892f56

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-05-11T09:53:58Z

Build Failed 😭

Build Id: e35ec88a-3848-4a70-8f87-3fe1b11a06e5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2026-05-12T06:30:05Z

/gcbrun

agones-bot · 2026-05-12T06:45:29Z

Build Failed 😭

Build Id: 0894d8f3-6aa3-484e-8c51-b7d089f35370

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-05-12T08:47:50Z

Build Failed 😭

Build Id: f680848d-d334-4731-a973-ddd02c1184e4

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-05-24T19:00:23Z

Build Failed 😭

Build Id: 441eecfa-987c-407a-9c93-4dfaa26a41b6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-05-24T20:57:25Z

Build Failed 😭

Build Id: c486f2ce-f194-47ec-a6cf-7a9112176a76

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2026-05-26T05:00:00Z

/gcbrun

agones-bot · 2026-05-26T05:14:34Z

Build Failed 😭

Build Id: 03abe090-4b08-4114-85dc-109f562c5d16

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch

GKE Autopilot does not support Windows Nodes https://docs.cloud.google.com/kubernetes-engine/docs/concepts/windows-server-gke#limitations. Try running tests on Standard only.

agones-bot · 2026-05-30T06:28:24Z

Build Failed 😭

Build Id: d9561616-5ef7-4585-9398-81a4d7bce436

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-05-30T06:55:42Z

Build Failed 😭

Build Id: d899272a-a35a-4aed-86fa-6eb15696a675

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-05-30T07:36:30Z

Build Failed 😭

Build Id: c4b35f9c-0c5d-421a-a377-e514d5730e33

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2026-06-12T03:57:56Z

Curious to hear how the work here is going? I can't see the clusters, but what is failing here?

Sivasankaran25 · 2026-06-12T04:13:42Z

Curious to hear how the work here is going? I can't see the clusters, but what is failing here?

The e2e-windows-smoke test step failed because GKE Autopilot does not support Windows nodes. The test must be configured to run only on GKE Standard clusters. Please suggest possible approaches to fix this build error.

markmandel · 2026-06-12T04:24:28Z

Could we use something like what we did here to skip autopilot?

agones/test/e2e/gameserver_test.go

Line 263 in 00f9151

    
           framework.SkipOnCloudProduct(t, "gke-autopilot", "does not support Static PortPolicy")

markmandel · 2026-07-08T20:57:53Z

+  # The test itself calls t.Skip() when CloudProduct == "gke-autopilot".
+  # Runs parallel with e2e-feature-gates to avoid adding wall-clock time.
+  #
+  - name: e2e-runner


I'll reiterate this - we have tests that only run on autopilot, why do we need this extra build step? This should just be a single extra test that runs on standard GKE clusters, that tests the windows nodes.

markmandel · 2026-07-08T20:58:23Z

+
+	gs := framework.DefaultGameServer(framework.Namespace)
+	gs.Spec.Template.Spec.NodeSelector = map[string]string{
+		"kubernetes.io/os": "windows",


Looks good.

markmandel · 2026-07-08T20:59:25Z

  - started-by-${_PARENT_BUILD_ID}
 timeout: 5400s  # 1.5h
-queueTtl: 7200s  # 2h // only one set of e2es should be running at once
-logsBucket: gs://agones-build-logs


Don't remove the log bucket - that's why I can't see the logs.

markmandel · 2026-07-08T21:00:05Z

+  #
+  # Run Windows GameServer smoke test.
+  # Windows nodes are NOT supported on GKE Autopilot:
+  # https://cloud.google.com/kubernetes-engine/docs/concepts/windows-server-gke#limitations
+  # The test itself calls t.Skip() when CloudProduct == "gke-autopilot".
+  # Runs parallel with e2e-feature-gates to avoid adding wall-clock time.
+  #
+  - name: e2e-runner
+    args:
+      - ${_FEATURE_WITHOUT_GATE}
+      - ${_CLOUD_PRODUCT}
+      - ${_TEST_CLUSTER_NAME}
+      - ${_TEST_CLUSTER_LOCATION}
+      - ${_REGISTRY}
+      - ${_GS_TEST_IMAGE}
+    id: e2e-windows-smoke
+    waitFor:
+      - build-e2e
+    timeout: 900s


Suggested change

#

# Run Windows GameServer smoke test.

# Windows nodes are NOT supported on GKE Autopilot:

# https://cloud.google.com/kubernetes-engine/docs/concepts/windows-server-gke#limitations

# The test itself calls t.Skip() when CloudProduct == "gke-autopilot".

# Runs parallel with e2e-feature-gates to avoid adding wall-clock time.

#

- name: e2e-runner

args:

- ${_FEATURE_WITHOUT_GATE}

- ${_CLOUD_PRODUCT}

- ${_TEST_CLUSTER_NAME}

- ${_TEST_CLUSTER_LOCATION}

- ${_REGISTRY}

- ${_GS_TEST_IMAGE}

id: e2e-windows-smoke

waitFor:

- build-e2e

timeout: 900s

timeout: 900s

markmandel · 2026-07-08T21:00:31Z

+func TestWindowsCreateConnect(t *testing.T) {
+	t.Parallel()
+
+	if framework.CloudProduct == "gke-autopilot" {


Since you have this, it should run as part of the standard set of e2e tests -- no need for the extra build step.

agones-bot · 2026-07-09T04:33:09Z

Build Failed 😭

Build Id: 2d8351fd-4531-43fd-8c89-bfbe5c8192dd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2026-07-09T04:43:21Z

/gcbrun

agones-bot · 2026-07-09T05:29:37Z

Build Failed 😭

Build Id: 1a5bebee-8115-4f71-a368-fb94b3d61bac

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch

Thanks for moving Windows GameServers to Beta! The docs and support-tier changes look right, and the Autopilot handling is correct — the test is skipped on Autopilot and the node pool is only added to the standard cluster.

However, TestWindowsCreateConnect will fail consistently on the standard e2e cluster (where it actually runs) for two reasons. Fixes are suggested inline, plus one blocker that lives outside this diff is that no Windows image is built for e2e:

cloudbuild.yaml:188 builds and pushes the e2e simple-game-server image with WITH_WINDOWS=0, so its manifest is linux/amd64-only (examples/simple-game-server/Makefile only adds the windows_amd64 layers when WITH_WINDOWS=1). The test comment claims framework.GameServerImage is multi-arch with a windows/amd64 variant — that isn't true in CI, so a Windows-pinned pod has no runnable image and never reaches Ready. This needs WITH_WINDOWS=1 for the e2e image build step:

      - 'WITH_WINDOWS=1'

Inline suggestions

Add the Windows node toleration and prefer the SkipOnCloudProduct helper (test file).
Set the Windows taint on the node pool and restore the missing trailing newline (module.tf).

Nice work overall — once the e2e image includes a Windows variant and the pod can tolerate/schedule onto the Windows node, this should go green.

igooch · 2026-07-09T17:42:21Z

+	if framework.CloudProduct == "gke-autopilot" {
+		t.Skip("Windows nodes are not supported on GKE Autopilot")
+	}
+
+	gs := framework.DefaultGameServer(framework.Namespace)
+	gs.Spec.Template.Spec.NodeSelector = map[string]string{
+		"kubernetes.io/os": "windows",
+	}
+	// framework.GameServerImage is multi-arch (linux/amd64 + windows/amd64),
+	// so no separate Windows-tagged image is required - the correct
+	// platform variant is selected automatically based on the node.
+	gs.Spec.Template.Spec.Containers[0].Image = framework.GameServerImage


🔴 GKE taints Windows nodes node.kubernetes.io/os=windows:NoSchedule, but DefaultGameServer sets no toleration, so the pod can't schedule onto the Windows node. Also prefer the existing SkipOnCloudProduct helper, and drop the multi-arch comment — the e2e image is built with WITH_WINDOWS=0 (see summary), so GameServerImage has no windows/amd64 variant today.

Suggested change

if framework.CloudProduct == "gke-autopilot" {

t.Skip("Windows nodes are not supported on GKE Autopilot")

}

gs := framework.DefaultGameServer(framework.Namespace)

gs.Spec.Template.Spec.NodeSelector = map[string]string{

"kubernetes.io/os": "windows",

}

// framework.GameServerImage is multi-arch (linux/amd64 + windows/amd64),

// so no separate Windows-tagged image is required - the correct

// platform variant is selected automatically based on the node.

gs.Spec.Template.Spec.Containers[0].Image = framework.GameServerImage

framework.SkipOnCloudProduct(t, "gke-autopilot", "Windows nodes are not supported on GKE Autopilot")

gs := framework.DefaultGameServer(framework.Namespace)

gs.Spec.Template.Spec.NodeSelector = map[string]string{

"kubernetes.io/os": "windows",

}

gs.Spec.Template.Spec.Tolerations = []corev1.Toleration{{

Key: "node.kubernetes.io/os",

Operator: corev1.TolerationOpEqual,

Value: "windows",

Effect: corev1.TaintEffectNoSchedule,

}}

gs.Spec.Template.Spec.Containers[0].Image = framework.GameServerImage

agones-bot · 2026-07-10T04:36:50Z

Build Failed 😭

Build Id: f6275ab8-4205-4849-a395-7f559c635004

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-07-15T05:38:47Z

Build Failed 😭

Build Id: 5915080e-be9a-40a2-bc48-888ba68fb9ab

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2026-08-09T01:24:09Z

@igooch , @Sivasankaran25 - we just waiting to create windows nodes on the clusters for this, yeah?

…esent

agones-bot · 2026-08-11T05:19:55Z

Build Failed 😭

Build Id: 3ded919e-20ab-412a-b289-85efa96f4422

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:56Z

Build Failed 😭

Build Id: a1865ae1-8638-4150-b98b-768841b449a6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:56Z

Build Succeeded 🥳

Build Id: 5b5b7b94-0ea1-4148-950b-951e139a581d

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.60.0-dev-2b6588e
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.60.0-dev-2b6588e
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.60.0-dev-2b6588e-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.60.0-dev-2b6588e
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.60.0-dev-2b6588e
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.60.0-dev-2b6588e
Linux C++ SDK (build): agonessdk-1.60.0-dev-2b6588e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.60.0-dev-2b6588e.zip

A preview of the website (the last 30 builds are retained):

https://2b6588e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4560/head:pr_4560 && git checkout pr_4560
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.60.0-dev-2b6588e

agones-bot · 2026-08-11T06:25:11Z

Build Succeeded 🥳

Build Id: e56c63ea-ca3f-4650-9fcf-75080f48b3c4

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.60.0-dev-7fda54b
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.60.0-dev-7fda54b
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.60.0-dev-7fda54b-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.60.0-dev-7fda54b
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.60.0-dev-7fda54b
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.60.0-dev-7fda54b
Linux C++ SDK (build): agonessdk-1.60.0-dev-7fda54b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.60.0-dev-7fda54b.zip

A preview of the website (the last 30 builds are retained):

https://7fda54b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4560/head:pr_4560 && git checkout pr_4560
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.60.0-dev-7fda54b

markmandel · 2026-08-16T21:24:46Z


 The following container operating systems and architectures can be utilised with Agones:

+{{% feature publishVersion="1.60.0" %}}


Since we've done a release, let's update these versions.

markmandel · 2026-08-16T21:27:59Z

+	t.Parallel()
+
+	framework.SkipOnCloudProduct(t, "gke-autopilot", "Windows nodes are not supported on GKE Autopilot")
+	skipIfNoWindowsNodes(t)


🤔 why do we want this? This feels like the sort of thing that would hide issues with testing the windows machines.

TBH, I didn't look, and assumed the tests where passing. I'd recommend removing this, because if we don't have windows nodes on a specific gke standard version, these tests should fail.

agones-bot · 2026-08-16T22:55:06Z

Build Succeeded 🥳

Build Id: 8a160c8d-620d-4803-9128-7fa6c9ea5c82

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.61.0-dev-7ae0658
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.61.0-dev-7ae0658
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.61.0-dev-7ae0658-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.61.0-dev-7ae0658
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.61.0-dev-7ae0658
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.61.0-dev-7ae0658
Linux C++ SDK (build): agonessdk-1.61.0-dev-7ae0658-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.61.0-dev-7ae0658.zip

A preview of the website (the last 30 builds are retained):

https://7ae0658-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4560/head:pr_4560 && git checkout pr_4560
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-7ae0658

agones-bot · 2026-08-17T04:33:06Z

Build Succeeded 🥳

Build Id: fb1c6e27-8c25-4e91-81f4-77478ab8c53b

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.61.0-dev-282b3f6
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.61.0-dev-282b3f6
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.61.0-dev-282b3f6-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.61.0-dev-282b3f6
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.61.0-dev-282b3f6
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.61.0-dev-282b3f6
Linux C++ SDK (build): agonessdk-1.61.0-dev-282b3f6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.61.0-dev-282b3f6.zip

A preview of the website (the last 30 builds are retained):

https://282b3f6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4560/head:pr_4560 && git checkout pr_4560
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-282b3f6

agones-bot · 2026-08-17T05:38:00Z

Build Failed 😭

Build Id: ea98727e-f680-44b6-9c6f-273de6741ba9

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Sivasankaran25 · 2026-08-17T06:01:59Z

/gcbrun

agones-bot · 2026-08-17T06:47:43Z

Build Failed 😭

Build Id: 8314269d-5d41-4d96-8d2f-834f5ef5e139

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Implmemnted Feature Windows Gameserver Move Alpha to beta

eea6c1f

Sivasankaran25 requested a review from a team May 11, 2026 09:01

Sivasankaran25 self-assigned this May 11, 2026

github-actions Bot added kind/feature New features for Agones size/M labels May 11, 2026

Fix e2e test cloudbuild.yam

7fef0af

Change Windows base lts

0470921

Merge branch 'main' into feature/widowsgameserver

6444191

fix: resolve CI failures in Windows GameServer Beta PR

317efc2

nikkisingh0204 approved these changes May 24, 2026

View reviewed changes

igooch reviewed May 28, 2026

View reviewed changes

Sivasankaran25 added 2 commits May 30, 2026 06:21

fix: skip Windows smoke test on GKE Autopilot

781b0a6

Merge branch 'main' into feature/widowsgameserver

acdd754

fix lint error

ee42814

fix: remove entrypoint bash from windows smoke step

9fe7d30

markmandel reviewed Jul 8, 2026

View reviewed changes

Sivasankaran25 added 2 commits July 9, 2026 03:50

cleanup(ci): remove e2e-windows-smoke build step

09afd41

Merge branch 'main' into feature/widowsgameserver

74cde1f

igooch reviewed Jul 9, 2026

View reviewed changes

Sivasankaran25 added 2 commits July 10, 2026 03:52

fix(e2e): fix Windows GameServer scheduling in TestWindowsCreateConnect

a97b606

Merge branch 'main' into feature/widowsgameserver

f5beb1b

Merge branch 'main' into feature/widowsgameserver

9f5c4be

Sivasankaran25 added 3 commits August 9, 2026 15:05

Merge branch 'main' into feature/widowsgameserver

c0be48c

test(e2e): skip TestWindowsCreateConnect when no Windows nodes are pr…

4ecbb4a

…esent

Fix Lint error

2b6588e

Merge branch 'main' into feature/widowsgameserver

7fda54b

Merge branch 'main' into feature/widowsgameserver

7ae0658

markmandel reviewed Aug 16, 2026

View reviewed changes

Merge branch 'main' into feature/widowsgameserver

282b3f6

fix: remove skipIfNoWindowsNodes guard, bump doc version to 1.61.0

0a1ec66


		The following container operating systems and architectures can be utilised with Agones:

		{{% feature publishVersion="1.60.0" %}}

Uh oh!

Conversation

Sivasankaran25 commented May 11, 2026

Uh oh!

agones-bot commented May 11, 2026

Uh oh!

agones-bot commented May 11, 2026

Uh oh!

Sivasankaran25 commented May 12, 2026

Uh oh!

agones-bot commented May 12, 2026

Uh oh!

agones-bot commented May 12, 2026

Uh oh!

agones-bot commented May 24, 2026

Uh oh!

agones-bot commented May 24, 2026

Uh oh!

Sivasankaran25 commented May 26, 2026

Uh oh!

agones-bot commented May 26, 2026

Uh oh!

igooch left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented May 30, 2026

Uh oh!

agones-bot commented May 30, 2026

Uh oh!

agones-bot commented May 30, 2026

Uh oh!

markmandel commented Jun 12, 2026

Uh oh!

Sivasankaran25 commented Jun 12, 2026

Uh oh!

markmandel commented Jun 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Jul 9, 2026

Uh oh!

Sivasankaran25 commented Jul 9, 2026

Uh oh!

agones-bot commented Jul 9, 2026

Uh oh!

igooch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

agones-bot commented Jul 10, 2026

Uh oh!

agones-bot commented Jul 15, 2026

Uh oh!

markmandel commented Aug 9, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Aug 16, 2026

igooch left a comment •

edited

Loading