Remove playertracking sdk alpha by indurireddy-TF · Pull Request #4671 · agones-dev/agones

indurireddy-TF · 2026-08-03T08:41:25Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4491

Did you use AI tools in preparing this PR?:

Y

Special notes for your reviewer:

github-actions · 2026-08-03T08:41:47Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2026-08-03T08:42:26Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2026-08-05T05:43:13Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2026-08-05T06:35:56Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

indurireddy-TF · 2026-08-05T07:21:27Z

/gcbrun

indurireddy-TF · 2026-08-05T07:29:13Z

Hi @markmandel , this PR is focused on SDK-related changes across all languages.

github-actions · 2026-08-07T03:38:26Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel · 2026-08-09T04:33:09Z

/gcbrun

github-actions · 2026-08-09T04:33:15Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

markmandel · 2026-08-09T04:34:28Z

/gcbrun

indurireddy-TF · 2026-08-10T14:47:52Z

/gcbrun

github-actions · 2026-08-10T17:02:46Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

indurireddy-TF · 2026-08-10T17:59:50Z

Hi @markmandel Found the e2e test failure from the child build and fixed the affected PlayerTracking tests. The build is passing now.

agones-bot · 2026-08-11T05:19:54Z

Build Failed 😭

Build Id: be54dad0-04b4-43db-9854-4702c7309b3a

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:54Z

Build Failed 😭

Build Id: 9017fe7a-30af-4b5e-9e41-d31b42e415f9

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:55Z

Build Failed 😭

Build Id: 3ed56f4d-285a-46f0-8e12-cca30107e3d6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:55Z

Build Failed 😭

Build Id: 40ed6c23-e35d-4289-a414-65caff125976

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:56Z

Build Failed 😭

Build Id: 0e78d63a-3fe2-4006-88da-c96240366496

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:56Z

Build Failed 😭

Build Id: 769bd658-e27e-4d63-97f4-b5099558394e

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-08-11T05:19:56Z

Build Succeeded 🥳

Build Id: 720d8c24-c84d-4615-85c3-65a1efe4fcfd

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.60.0-dev-13cf101
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.60.0-dev-13cf101
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.60.0-dev-13cf101-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.60.0-dev-13cf101
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.60.0-dev-13cf101
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.60.0-dev-13cf101
Linux C++ SDK (build): agonessdk-1.60.0-dev-13cf101-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.60.0-dev-13cf101.zip

A preview of the website (the last 30 builds are retained):

https://13cf101-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4671/head:pr_4671 && git checkout pr_4671
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.60.0-dev-13cf101

github-actions · 2026-08-11T08:50:28Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-08-11T08:55:45Z

Build Failed 😭

Build Id: e1176d73-0a4e-44d6-a222-d2c251cab5f2

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2026-08-11T09:04:27Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2026-08-11T09:51:59Z

Build Failed 😭

Build Id: 53b8d50e-a6f2-4f9a-98c5-8dadab6c3bbc

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

indurireddy-TF · 2026-08-11T10:25:50Z

/gcbrun

agones-bot · 2026-08-11T11:21:19Z

Build Succeeded 🥳

Build Id: c6e78431-f57e-4cd3-86cc-e66f6011160e

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.60.0-dev-e6db614
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.60.0-dev-e6db614
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.60.0-dev-e6db614-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.60.0-dev-e6db614
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.60.0-dev-e6db614
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.60.0-dev-e6db614
Linux C++ SDK (build): agonessdk-1.60.0-dev-e6db614-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.60.0-dev-e6db614.zip

A preview of the website (the last 30 builds are retained):

https://e6db614-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4671/head:pr_4671 && git checkout pr_4671
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.60.0-dev-e6db614

markmandel

Whew! Lots of stuff going away - I love it.

I stopped after a bit, but I think we should keep all the alpha harnesses and stubs across the code base, but leave them as empty. We built all of it out, and when we have alpha sdk methods again, we'll want it all back - so let's not delete it all outright, let's leave empty stubs, interfaces etc so they are there when we are looking to build out alpha features.

markmandel · 2026-08-18T15:35:09Z

 COMMAND ?= gen
 SDK_IMAGE_TAG=$(build_sdk_prefix)$(SDK_FOLDER):$(build_sdk_version)
 DEFAULT_CONFORMANCE_TESTS = ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve
-ALPHA_CONFORMANCE_TESTS = getplayercapacity,setplayercapacity,playerconnect,playerdisconnect,getplayercount,isplayerconnected,getconnectedplayers


Can we keep ALPHA_CONFORMANCE_TESTS but just as an empty value? Then we maintain the harness if we need it.

markmandel · 2026-08-18T15:35:43Z

 	# run with on-by-default (Beta) feature flags enabled
 	$(MAKE) run-sdk-conformance-test SDK_FOLDER=go GRPC_PORT=9001 HTTP_PORT=9101 TESTS=$(DEFAULT_CONFORMANCE_TESTS),$(COUNTS_AND_LISTS_TESTS)
-	# run with Alpha and Beta feature flags enabled
-	$(MAKE) run-sdk-conformance-test SDK_FOLDER=go GRPC_PORT=9001 HTTP_PORT=9101 FEATURE_GATES=$(ALPHA_FEATURE_GATES) TESTS=$(DEFAULT_CONFORMANCE_TESTS),$(ALPHA_CONFORMANCE_TESTS),$(COUNTS_AND_LISTS_TESTS)


Same as above, let's not delete all this just to have to put it back when we next have alpha features. Same goes for everything else in this file.

If want to get fancy, we could look for a way to have "if ALPHA_CONFORMANCE_TESTS is null, then don't run the second tests" -- but since make can be tricky with conditionals like that, I don't think it's 100% a necessity.

markmandel · 2026-08-18T15:38:30Z

 const DEFAULT_TIMEOUT = 60;
 const MAX_TIMEOUT = 2147483;

-const connect = async (timeout, enableAlpha, enableBeta) => {


Same thing here - let's not remove the ability to have alpha SDKs - we can keep the harnesses, just leave them empty. Probably with a comment saying something like "if you have alpha features, put them here"

markmandel · 2026-08-18T15:39:32Z

 $ npm start -- --timeout=0
 ```
-
-To enable alpha features ensure the feature gate is enabled:


Keep all this. There may be no alpha features, but again, let's not drop the harness we built for it all.

markmandel · 2026-08-18T15:40:11Z

 	"LABEL":                handleLabel,
 	"CRASH":                handleCrash,
 	"ANNOTATION":           handleAnnotation,
-	"PLAYER_CAPACITY":      handlePlayerCapacity,


Makes sense - this warrants a bump in version though.

markmandel · 2026-08-18T15:40:42Z

 	log.SetPrefix("[wrapper] ")
 	input := flag.String("i", "", "the command and arguments to execute the server binary")

-	// Since player tracking is not on by default, it is behind this flag.


This makes sense - but warrants a example image version bump.

markmandel · 2026-08-18T15:41:09Z

-            body: "*"
-        };
-    }
+service SDK {}


Nice! Yeah, this is still here, but we just have an empty service. 👍🏻

markmandel · 2026-08-18T15:41:29Z

    }

    message Status {
+         reserved 4;


Nice! Love the reserved.

markmandel · 2026-08-18T15:44:34Z

-		/// Alpha returns the Alpha SDK
-		/// </summary>
-		/// <returns>Agones alpha SDK</returns>
-		public IAgonesAlphaSDK Alpha()


Rather than delete it all, have an empty interface, and still keep the alpha setup etc -- so the basic structure is still there.

markmandel · 2026-08-18T15:45:01Z

 }

-// Alpha returns the Alpha SDK.
-func (s *SDK) Alpha() *Alpha {


Same here - we should keep the Alpha(), but have it be empty.

agones-bot · 2026-08-18T17:15:32Z

Build Succeeded 🥳

Build Id: 90b964b5-4d85-44cf-b5e4-8e6a1bff54fa

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.61.0-dev-f2638e5
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.61.0-dev-f2638e5
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.61.0-dev-f2638e5-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.61.0-dev-f2638e5
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.61.0-dev-f2638e5
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.61.0-dev-f2638e5
Linux C++ SDK (build): agonessdk-1.61.0-dev-f2638e5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.61.0-dev-f2638e5.zip

A preview of the website (the last 30 builds are retained):

https://f2638e5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4671/head:pr_4671 && git checkout pr_4671
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-f2638e5

github-actions · 2026-08-18T18:39:21Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

indurireddy-TF added 4 commits July 1, 2026 20:22

Preparation for Release v1.60.0

f0d798f

Merge branch 'agones-dev:main' into main

37caa80

Merge branch 'agones-dev:main' into main

3fb9728

Merge branch 'agones-dev:main' into main

82702ad

github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XL labels Aug 3, 2026

Merge branch 'agones-dev:main' into main

737d2f8

indurireddy-TF force-pushed the remove-playertracking-sdk-alpha branch from feaf9ab to ebff1b6 Compare August 5, 2026 05:42

indurireddy-TF requested a review from markmandel August 5, 2026 07:27

Merge branch 'agones-dev:main' into main

55f189d

indurireddy-TF added 5 commits August 11, 2026 08:36

Merge branch 'agones-dev:main' into main

6c094b0

Remove PlayerTracking alpha SDK methods

803d8a8

Regenerate SDK files after rebase

d906292

Regenerate C++ SDK files with updated protobuf

cd3e0c6

fix-e2e-tests

21978db

indurireddy-TF force-pushed the remove-playertracking-sdk-alpha branch from 13cf101 to 21978db Compare August 11, 2026 08:50

Regenerate alpha Swagger after PlayerTracking removal

e6db614

Merge branch 'main' into remove-playertracking-sdk-alpha

f2638e5

markmandel reviewed Aug 18, 2026

View reviewed changes

Uh oh!

Conversation

indurireddy-TF commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

indurireddy-TF commented Aug 5, 2026

Uh oh!

indurireddy-TF commented Aug 5, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

markmandel commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

markmandel commented Aug 9, 2026

Uh oh!

indurireddy-TF commented Aug 10, 2026

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

indurireddy-TF commented Aug 10, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

indurireddy-TF commented Aug 11, 2026

Uh oh!

agones-bot commented Aug 11, 2026

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment