Skip to content

feat: use new errors pkg in pkg/fleetautoscalers/* - #4711

Open
lacroixthomas wants to merge 6 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-in-fleetautoscaler-pkg
Open

feat: use new errors pkg in pkg/fleetautoscalers/*#4711
lacroixthomas wants to merge 6 commits into
agones-dev:mainfrom
lacroixthomas:features/integrate-errors-in-fleetautoscaler-pkg

Conversation

@lacroixthomas

Copy link
Copy Markdown
Collaborator

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:

Use the new error package (https://github.com/agones-dev/agones/blob/main/pkg/util/errors/errors.go) on the pkg/fleetautoscalers/* files

Which issue(s) this PR fixes:
Work on #4510

Did you use AI tools in preparing this PR?:
Y

Special notes for your reviewer:

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@lacroixthomas
lacroixthomas marked this pull request as ready for review September 3, 2026 22:34
@lacroixthomas
lacroixthomas requested a review from a team September 3, 2026 22:35
@github-actions github-actions Bot added kind/cleanup Refactoring code, fixing up documentation, etc size/M labels Sep 3, 2026
@agones-bot

Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 97b67311-ec0b-4f8d-a0d5-e500c478a531

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: bbc66781-3741-4c34-85fc-f11db9449778

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4711/head:pr_4711 && git checkout pr_4711
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-dc7cf08

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 1c2bc5b2-1675-4ce1-ad02-977bc7a04dea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4711/head:pr_4711 && git checkout pr_4711
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-9884178

@agones-bot

Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 842cf071-8ce6-4fe5-a766-66f41b4bad0a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4711/head:pr_4711 && git checkout pr_4711
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.61.0-dev-61c6cc6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants