Skip to content

fix(review): harden file access and review boundaries - #6

Merged
ahmedragab20 merged 43 commits into
mainfrom
fix/review-native-file-access
Sep 7, 2026
Merged

fix(review): harden file access and review boundaries#6
ahmedragab20 merged 43 commits into
mainfrom
fix/review-native-file-access

Conversation

@ahmedragab20

Copy link
Copy Markdown
Owner

Summary

  • Enforce HTML/API auth boundaries and same-origin token attachment; bound code-comment requests and safely serialize TS/Rust XML.
  • Correct hunk-based totals and route selected preview/edit/image operations through a pinned Rust filesystem helper.
  • Preserve native executable permissions in pnpm archives; document the implemented contract and deferred work in docs/hardening-status.md.
  • Preserve existing formatting cleanup.

Verified

  • Latest full suite: 1,747 TS tests across 167 files; 306 Rust tests.
  • Final native-bundle suite: 5 tests, including a real seven-target fixture tarball.
  • pnpm build, 18 bundle checks, docs build (25 pages).
  • 14 packaged-layout API checks: reads/writes, hashes, CSP, literal paths, symlink/traversal denial, and fail-closed behavior without the helper.
  • Built UI rendering and persisted comment checked; no live inference.

Known limits / next agent

  • Typecheck still has 47 baseline errors across 18 files.
  • A02 remains partial, not a repository sandbox. Legacy untracked/EditorConfig/Git/editor/fff access is not fully contained; the browser smoke reproduced the untracked symlink gap.
  • Exact historical preview sides, durable state, complete contract parity, full browser edit workflow, cross-platform runtime verification and other deferred criteria are in the handoff.
  • Local diffing continuation plan: http://127.0.0.1:61829/plan/148793ce-fc0f-4865-9202-6523fb34e157

No release published. Remaining work was explicitly deferred by the owner.

@ahmedragab20
ahmedragab20 merged commit 0a062c6 into main Sep 7, 2026
7 checks passed
@ahmedragab20
ahmedragab20 deleted the fix/review-native-file-access branch September 7, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant