fix(controllers): write command interfaces on deactivation - #254
Merged
Conversation
Member
Author
|
Actually, this is a bit annoying because main already contains breaking changes and we can't release this a hotfix. Let me think about it |
domire8
commented
May 28, 2026
Member
Author
|
Now upon squash and merge, the CI will build a 5.4.2 release. I can then protect the branch and we never need to touch it again. |
SprGrf
approved these changes
Jun 1, 2026
|
|
||
| metadata: | ||
| name: Get metadata | ||
| needs: check-version |
There was a problem hiding this comment.
Out of curiosity, this is not enough? You also have to remove it above?
Member
Author
There was a problem hiding this comment.
Yes I guess this would be enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One would expect that if a controller sets its command to zero on deactivate that this would stop the robot. However, the controller base class failed to propagate this zero command to the hardware so far. This fixes it.
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: