-
Notifications
You must be signed in to change notification settings - Fork 18
Feat/retire aimdb ws protocol #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lxsaah
wants to merge
54
commits into
main
Choose a base branch
from
feat/retire-aimdb-ws-protocol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
9255ab3
docs(design): add 045 — retire aimdb-ws-protocol, converge every tran…
33e2c4c
feat(core): wildcard subscribe + topic-tagged subscription streams fo…
89d8209
feat(websocket-connector): speak AimX on the WebSocket transport (des…
2ea53d2
feat(wasm-adapter): rewrite WsBridge on run_client with the AimX code…
a8a40e2
chore(workspace): delete aimdb-ws-protocol and retire the ws wire res…
377869c
chore(external): update embassy subproject commit reference
12bdbdb
Merge branch 'main' into feat/retire-aimdb-ws-protocol
lxsaah c49e9ef
feat: retire aimdb-ws-protocol in favor of AimX, update related compo…
lxsaah 9fb3be1
feat: add embassy-futures dependency and update embassy submodule
lxsaah 74fd1b8
fix README output
lxsaah 94fd894
feat: remove aimdb-ws-protocol and update related components to AimX
lxsaah cbf715b
feat: enhance safety for wasm32 by feature-gating Send and Sync for C…
lxsaah 8d2d6ac
feat: update AimX protocol to version 3.0 with breaking changes in ha…
lxsaah 9da13a9
feat: update topic separator from '/' to '.' for wildcard subscriptio…
lxsaah c70263f
feat: enhance subscription updates to include skipped record count
lxsaah 2ef058f
Refactor documentation and comments across multiple modules
lxsaah c06b07e
feat: remove collect_outbound_topic_type_ids method from AimDb
lxsaah 1714e62
feat: add fan-out encoding benchmarks for allocation and latency comp…
lxsaah 548de31
feat: add fan-out socket-driven benchmark for performance measurement
lxsaah 266e34b
feat: add splicing method for outbound event data to optimize seriali…
lxsaah 0fa1346
format
lxsaah aba0fef
feat: refine SendFuture implementation and simplify recv method in Wa…
lxsaah 182849a
Merge branch 'main' into feat/retire-aimdb-ws-protocol
lxsaah e8b2cb9
perf(remote): carry subscribe updates as JSON bytes, not a Value tree
lxsaah 9d0930d
format
lxsaah 60fd1e1
Merge branch 'main' into feat/retire-aimdb-ws-protocol
lxsaah a32b05e
chore: update changelogs and design documents to reflect Design 047 c…
lxsaah ce23c1a
doc: add contract clarification for write_frame_splicing_data function
lxsaah c9a803e
feat: implement pattern containment check for subscription ACLs
lxsaah da0db91
feat: implement WebSocket protocol versioning via upgrade URL for Aim…
lxsaah eadfab1
fix: clarify serialization behavior in write_frame and add assertions…
lxsaah a61c02b
chore: update changelogs and documentation to reflect design 047 changes
lxsaah a5ac2e2
feat: enhance broadcast mechanism to surface dropped updates as seq gaps
lxsaah baf1327
fix: update subscription topic syntax from 'sensors/#' to 'sensors.#'…
lxsaah 7bcdcf9
fix: clarify documentation for SendFuture and its safety guarantees i…
lxsaah ce990f1
feat: add CancelToken and CancelHandle for wasm-runtime support
lxsaah 0d35d19
fix: ensure non-terminal `#` in grants only covers its suffix
lxsaah 443631b
feat: implement late-join snapshot sequence numbering to improve loss…
lxsaah eaab01d
feat: implement loss-aware subscription updates and reporting for Aim…
lxsaah 182bd47
feat: enhance WebSocket connection handling and add integration tests…
lxsaah 97f475e
feat: update WebSocket connection URL to use versioned endpoint
lxsaah 9dfb52d
feat: implement pending call management to reclaim abandoned calls in…
lxsaah 5b5b081
feat: enhance late-join snapshot handling with sequence numbering and…
lxsaah 153a9da
feat: enhance snapshot handling and error logging in client-server co…
lxsaah 4d4afa1
feat: implement cancellation for abandoned calls in client engine to …
lxsaah 1987cc6
feat: limit inbound frame funnel to prevent memory overflow and impro…
lxsaah ab7755e
feat: add headless browser toolchain for WASM tests and ensure Chrome…
lxsaah 8e73a32
feat: add Docker features to devcontainer configuration for improved …
lxsaah 118d7ba
Merge branch 'main' into feat/retire-aimdb-ws-protocol
lxsaah 81696c7
chore: update subproject commit reference for embassy
lxsaah cd8b66c
feat: add WASM browser test workflow and update README with new make …
lxsaah 1d12efc
ci: capture Chrome failure detail for transform_join browser hang
lxsaah 67d0110
fix(wasm): upgrade wasm-bindgen family to unbreak browser tests
lxsaah 144df05
ci: drop transform_join browser hang diagnostic
lxsaah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The browser regressions are still not executed by CI yet.
This step verifies Chrome/chromedriver versions and opens
about:blank, but no workflow runsmake wasm-test.make checkdepends ontest-wasm, which is only a wasm32cargo check, so the actual browser-onlydial_testsremain unexecuted even though CI is green.I guess we may add a CI step that runs
make wasm-testand add the requestedFRAME_QUEUE_CAPoverflow regression? The new toolchain is present now, but it is not yet exercising the code it was added for.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI now runs the browser tests:
cd8b66cadds awasm-browser-testsjob that runsmake wasm-test. Getting it green also tookwebdriver.json(Chrome will not start on the runner without--no-sandbox).make checkstill works without a browser and the browser job is separate so a flaky Chrome cannot block the other checks.It also took the wasm-bindgen upgrade in
67d0110. 0.2.105 generated a duplicate JS identifier, so the glue failed to parse and no test ever started (only in CI), because symbol mangling depends on the compiler and the devcontainer is on 1.91.1 while@stableis on 1.97.1. Nothing declares that gap, so I filed #207 to pin the toolchain. It is a separate change, not this PR.The
FRAME_QUEUE_CAPoverflow test is not here on purpose: it checks a status change the bridge does not make yet.Dropremovesonclosewithout touchingshared.status, so withautoReconnect: falsethe JS side keeps reading"connected". It will land in the same commit as that fix,together with the pending-dial cancellation from the other thread.