Docker support by LongusBongus · Pull Request #14 · aktin/debian-updateagent-pkg

LongusBongus · 2026-06-25T12:57:44Z

AKTIN update agent supports upgrading docker DWHs. Mainly added 2 new sockets for update requests from the new DWH backend aktin/dwh-admin@master...docker-update-extension. These sockets are called over an internal Gateway added to the compose.yml file in this PR: aktin/docker-aktin-dwh@main...docker-update-extension

…teagent-pkg into docker-support merging socket changes to new pipeline feature

akomii · 2026-06-29T14:01:25Z

+curl -LO https://github.com/aktin/docker-aktin-dwh/releases/latest/download/compose.yml
+sudo docker compose pull
+sudo docker compose up -d
+#sudo docker image prune -f


Why is this line commented out but still in the file?

This line is declared optional inside our manual. I was not sure if we should automate the pruning of the old images, especially if the update fails and we are forced to fall back on the older images. What is your opinion about this?

Commented-out code should be removed. No execptions

akomii · 2026-06-29T14:04:46Z

-SocketUser=wildfly
-SocketGroup=wildfly


Whats the reason to remove the user wildfly here??

With the wildfly user set, the update agent depends on the wildfly user existing, when creating the sockets, which happens in the postinstall step. Say we install update agent on a host only containing docker DWHs, there exists no user called wildfly on the host. Therefore update agent install terminates early with an error.

I opened another issue on that #7

akomii · 2026-07-21T13:04:57Z

-  log_success "Wildfly permissions set successfully"
+#save_array() {
+#  local arr="$1"
+#  local var_name="$2"


never leave commented out code in the pr

akomii · 2026-07-21T13:26:06Z

 CLEANUP=false
 SKIP_BUILD=false
 FULL_CLEAN=false
+update_dir="/var/lib/aktin/update"


globals uppercase and readonly if immutable

akomii · 2026-07-21T13:39:12Z

+        exit 1
+      fi
+
+      cat <<EOF > "summary_aktin-updateagent_preinstall.txt"


This summary file is broken in three ways:

The heredoc lines are indented and quoted, so the file contains "debian_installed=0" literally. Sourcing it later produces command not found instead of a variable assignment.

It is written to a relative path, so it lands in dpkg's working directory (usually /) and is never cleaned up.

An exit status of 0 means installed, so the file records debian_installed=0 for an installed DWH, which reads as false.

akomii · 2026-07-21T13:39:13Z

+      log_info "debian dwh status: $debian_status"
+      log_info "docker dwh status: $docker_status"
+
+      if ! is_installed_debian && ! is_installed_docker; then


Two issues here:

Aborting installation contradicts the README, which states the base package installs without a DWH instance. It also breaks apt install ordering, installing the agent before the DWH becomes impossible. Failing preinst on a missing runtime environment is against Debian packaging practice. I would keep the package installable and no-op instead.

is_installed_debian and is_installed_docker are called a second time here even though their results were already captured in debian_status and docker_status above

akomii · 2026-07-21T13:39:14Z

+
+# Requirement: Any kind of dwh has to be installed
+is_installed_debian() {
+  if systemctl list-unit-files | grep -q "wildfly"; then


grep -q "wildfly" matches any unit whose name contains the substring. DEBIAN_SERVICE is declared on line 17 but never used...

akomii · 2026-07-21T13:39:41Z

 sudo apt-get install -f  # Install missing dependencies if any
 ```

+The base package installs without requiring an AKTIN DWH instance. Instance-specific runtime setup is handled separately:


This section contradicts the implementation in three places:

It says the base package installs without a DWH instance, but preinst aborts in exactly that case.

It says socket-setup configure is a separate manual step, but postinst calls it automatically.

It says the helper applies wildfly ownership, but that code is commented out.

akomii · 2026-07-21T13:39:42Z

 - `info`: Contains current and candidate version information
 - `log`: Update execution logs
 - `result`: Update execution results with success status
+- `docker-info`: Placeholder output for Docker version information


docker-info and docker-result do not match the implementation, the docker services write info and result into the docker volume's update directory.

akomii · 2026-07-21T13:57:38Z

+curl -LO https://github.com/aktin/docker-aktin-dwh/releases/latest/download/compose.yml
+sudo docker compose pull
+sudo docker compose up -d
+#sudo docker image prune -f


Commented-out code should be removed. No execptions

akomii · 2026-07-21T13:58:22Z

+docker_wait_for_deployment "$wildfly_container"
+successful="$(docker_post_update_validation $wildfly_container $update_dir)"
+
+$(journalctl -u 'aktin-notaufnahme-updateagent-docker*' -f) > $update_dir/log


Additionally, the unit name is hardcoded instead of using __PACKAGE_NAME__

akomii · 2026-07-21T14:01:26Z

+#      require_wildfly_user
+#      require_systemd


Why are these commented out?

akomii

Some changes necessary

WHoy and others added 30 commits April 7, 2026 14:54

new-sockets-for-docker

0bd3f6c

docker-sockets-contain-tcp-adresses

4b376bc

removed-debian-dwh-dependency

458ed19

removing-instance-dependancy-from-pipeline

120b8ac

test-script-for-deploying-updateagent

31419ed

added-parameters-to-deploy-script

ba7a848

renamed-setup-helper-script

3f2b27a

use-socket-intall-script-inside-postinst

89bdaf4

add-dynamic-update-dir-creation

73bf025

fix:manual-rename-from-instance-setup-file

55aa66f

fix:injection-error

7abadfd

working-on-socket-tcp-handling

746ac20

added minimal multipass test env

04f9019

initial-github-pipeline-for-tesing-docker-extension

e21149a

testing-pipeline-visibility

e5f390b

pipeline-installing-updateagent

be8dace

fix:pipeline-installing-updateagent

73ac7ad

fix:pipeline-missing-superuser

53fa371

fix:pipeline-missing-superuser-and-removed-dependencies

60883a7

fix:pipeline-path-mismatch

326768a

pipeline-end-of-day-commit

401e7b6

removed-wildfly-user-dependency

55ab1a6

Merge branch 'docker-support' of https://github.com/aktin/debian-upda…

73c6bbf

…teagent-pkg into docker-support merging socket changes to new pipeline feature

pipeline-installs-native-dwh

647d218

pipeline-add-steup-for-r

ddded74

replaced-native-dwh-wit-docker-instance

291c903

pipeline-install-required-packages

b1ebde8

pipeline-seperate-verification-step-for-docker-dwh

50aca1c

pipeline-installing-oder-dwh-for-testing

ac70e6c

pipeline-dwh-installation

77c5555

WHoy and others added 18 commits June 23, 2026 09:22

Docker update logic

bd6b8fa

fix navigate to compose directory not file itself

f52a36e

fix docker compose resolve

5e03784

fix moved rate limit settings to unit section, before it was ignored

36690cc

check for update status after finished and some log persistment

bf0148e

fix: forcing image prune

2b0d52a

removed pruning because it fails

cefb470

changed logging to display inside journalctl

bd63ec5

more logging

838462f

fix: waiting for wildfly to deploy before continuing the script

702cf80

fix: logging function did not work anymore

fbe7300

fix: corrected candidate version fetch

701369a

remove cleanup because ui depends on it

b959a9e

sourced helper functions to improve code. Updated script documentation

5c70f52

fix: missing closing argument

e75349b

fix: native wildfly check now unambiguous

90bff89

fix: path to helper script

1a84fb7

fix: typo

e395df7

LongusBongus requested a review from akomii June 25, 2026 12:57

LongusBongus self-assigned this Jun 25, 2026

LongusBongus added this to AKTIN Project Jun 25, 2026

LongusBongus added the enhancement New feature or request label Jun 25, 2026

github-project-automation Bot moved this to Todo in AKTIN Project Jun 25, 2026

fix: journalctl logging

a795037

akomii requested changes Jun 30, 2026

View reviewed changes

github-project-automation Bot moved this from Todo to In Progress in AKTIN Project Jun 30, 2026

WHoy added 2 commits July 17, 2026 12:33

removed-old-files

361494a

moved debian and docker scripts into seperate directories

5bf11e5

akomii requested changes Jul 21, 2026

View reviewed changes

		SocketUser=wildfly
		SocketGroup=wildfly

Uh oh!

Conversation

LongusBongus commented Jun 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LongusBongus Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akomii left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LongusBongus Jul 17, 2026 •

edited

Loading