Carry trial conditions and primary completion - #13
Merged
Conversation
Slide-in trial detail needs primary completion date alongside the existing start/end dates. The column was previously dropped during bronze-to-silver; preserve it and rename to primarycompletiondate matching the snake-no-underscore convention of the other date columns.
Adds two columns to fact_clinical_trial_event so the clinical-trial slide-in can show Conditions and the Primary completion milestone in its Timeline strip. primary_completion_date_key is an FK to dim_date, matching the existing start_date_key / end_date_key pattern.
The two-element list on `new_primarycompletiondate` exceeded Ruff's print width once the date strings were filled in. Reformat to one element per line, matching the project's existing format style and the precedent set by commit 04caad6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.