fix(copilot): let a chat interrupted mid tool call resume - #43
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A run killed mid-tool (deploy, OOM, cancelled stream, dead worker) stores an assistant turn whose tool part has no result — and half-written parts can also miss fields their state requires (
output-errorwith noerrorText,output-availablewith nooutput). That message then failedvalidateUIMessageson every subsequent send, and the route reported it as"Copilot unavailable. Run pnpm db:generate…", so the channel stayed stuck until the bad message aged out of the 500-message window.Two new pieces in
lib/copilot/messages.ts:validateResumableUIMessagesreplacesvalidateUIMessageson every path that reads a stored or client transcript:POST /api/ai/chat,executeChatRun, the dead-attempt takeover, stale-run expiry, andchat.persistMessages. A single unusable message can no longer block the whole channel.Model-side,
sanitizeUiMessagesForModelnow repairs before filtering, so an interrupted call reaches the model as a failed tool result instead of silently vanishing from the transcript.stripOrphanToolResultsis the mirror of the existingstripOrphanToolCalls(a result whose call fell out of the window is just as invalid);pairToolCallsWithResultsapplies both wherever the converted prompt is built.Link to Devin session: https://app.devin.ai/sessions/27a2860693d444f8a9a37442a83762d7
Requested by: @alanshen27