fix(cad): surface Zoo error detail in CAD generation rejections - #44
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text_to_cadmulti-part generations report every failing part as:The Zoo WebSocket
errorframe actually carriesdetail(and sometimeserror_code/request_id), buterrorDetail()inpackages/cad/src/zookeeper.tswas collapsing it to the generic string regardless of the payload.Changes
errorDetail()now extractserrorstring /detail/messageand includescode=/request_id=metadata.errorDetail()and adds unit tests for string errors, object details, code/request_id metadata, long-value truncation, and the fallback generic message.This makes
enclosure_shell,rear_cover,kickstand, etc. failures actionable instead of opaque — the next rejection will show the actual Zoo reason (e.g. quota, unsupported geometry, bad request).Link to Devin session: https://app.devin.ai/sessions/d846e91524fc43aca04de9649aeb2300
Requested by: @alanshen27