feat(cad): iterate on failing KCL in retries and add Zoo engine prompt guardrails - #47
Merged
Merged
Conversation
…t guardrails Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cuts the dominant cost in long
text_to_cadruns: a self-heal retry used to callcad.textToCadagain with an emptymain.kcl, so Zoo rewrote the whole part from scratch (the ~15-minuterear_coverretry in the analyzed logs). Retries now patch the failing script instead, and every prompt carries guardrails for the engine limits Zoo's model keeps hitting.text_to_cadretry path intools.ts:lastKclis captured when engine verification fails; generation-level failures (no KCL produced) still regenerate.apps/web/lib/cad/zoo-guardrails.ts—KCL_ENGINE_GUARDRAILSappended to all generation prompts:union()/subtract()of separate solids (model one closed-profile extrusion, cut from it) — matches theThe Zoo engine cannot handle this 3D union/subtraction yetfailures;point()takes noconstructionargument — a recurring model hallucination.Tests
zoo-guardrails.test.tscoverswithKclGuardrails,buildRegeneratePrompt,buildFixIteratePrompt.pnpm --filter @foundry/web test(484), lint, typecheck, format all pass.Link to Devin session: https://app.devin.ai/sessions/d846e91524fc43aca04de9649aeb2300
Requested by: @alanshen27