⬆️ Update to Aspire 13.5.0 - #19
Merged
Merged
Conversation
Bump Aspire.Hosting and the Aspire.AppHost.Sdk from 13.4.6 to 13.5.0 and refresh the lock files. Two source changes were needed - 13.5 is not drop-in: - HttpsCertificateConfigurationCallbackAnnotationContext gained a required CertificateWithKeyPath member (cert + key concatenated as PEM), which is a compile error wherever the context is constructed by hand. Only the tests do that; the resource's own callback still reads PfxPath. - DistributedApplicationExecutionContextOptions.ServiceProvider is obsolete in favour of Services. The certificate APIs are still experimental in 13.5, so the ASPIRECERTIFICATES001 suppressions stay; version mentions in the package README and the suppression comments were updated to match. Verified with a real `aspire run` of AspireDemo: both resources come up Healthy and the proxy forwards to the backend over HTTPS.
The 4.x adapter still runs xunit v1/v2/v3, so it pairs fine with the xunit 2.9.3 the test projects use; the major bump is about dropping older Visual Studio and target-framework support. Everything else in Directory.Packages.props is already current - the Test SDK and container-tools bumps landed on main via dependabot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
Aspire 13.5.0
Aspire.HostingandAspire.AppHost.Sdk13.4.6 → 13.5.0, lock files refreshed.13.5 is not drop-in — two source changes were needed:
HttpsCertificateConfigurationCallbackAnnotationContextgained a requiredCertificateWithKeyPathmember (cert + key concatenated as PEM). That's a compile error anywhere the context is constructed by hand, which here is onlyWhen_supplying_a_certificate; the resource's own callback still readsPfxPathand was unaffected.DistributedApplicationExecutionContextOptions.ServiceProvideris obsolete in favour ofServices.The certificate APIs are still experimental in 13.5, so the
ASPIRECERTIFICATES001suppressions stay. Version mentions in the package README and the suppression comments were updated, and the stated requirement moves to Aspire 13.5.0+.xunit.runner.visualstudio 4.0.0
The 4.x adapter still runs xunit v1/v2/v3 (confirmed in the 4.0.0 nuspec), so it pairs fine with the xunit 2.9.3 the test projects pin — the major is about dropping older Visual Studio and TFM support.
Verification
dotnet build/dotnet test -c Release: green, 7 proxy + 13 hosting tests.dotnet publish -t:PublishContainer: image builds ontomcr.microsoft.com/dotnet/aspnet:10.0-noble-chiseled-extraand writes the archive — same path CI verifies.aspire runofAspireDemo: bothdemoappandeasyauthcome up Running/Healthy, andaspire logs easyauthconfirms YARP forwarding to the backend over HTTPS.Known, deliberately not addressed
13.5 adds warning ASPIRE010 on the AppHost build, nudging toward
AspireUseCliBundle=true. Left as-is on purpose: flipping it drops theAspire.Dashboard.Sdk.*/Aspire.Hosting.Orchestration.*NuGet packages in favour of a machine-local CLI bundle, which would need an Aspire CLI install step in CI and would take DCP/dashboard out of lock-file coverage. CI never runs the AppHost, so there's no benefit today. The warning stays as an active reminder — the ASPIRE009 text notes these packages will be deprecated eventually, so this wants its own change later.