use float type for zoom - #8
Open
caramelli wants to merge 1 commit into
Open
Conversation
Owner
|
Nicolas Caramelli <notifications@github.com> wrote:
fbpdf was used for my presentation on the Linux Framebuffer at FOSDEM 2020 (https://fosdem.org/2020/schedule/event/fbdev).
I replaced the "int" type by "float" for the zoom variable in order to fill the entire screen when using 'f' or 'w' command.
Thanks for this great tool !
I have seen the slides before by accident and enjoined it a lot.
Thanks for the presentation.
Personally I prefer not to use floating point types, unless
quite necessary; and if zoom is float, zoom_def and mark_row
have to be also. Instead, I changed them to store zoom level
in percentage. Please give it a try.
Ali
|
Author
|
Perfect!
Nicolas Caramelli
Le dim. 14 juin 2020 à 13:29, Ali Gholami Rudi <notifications@github.com> a
écrit :
… Nicolas Caramelli ***@***.***> wrote:
> fbpdf was used for my presentation on the Linux Framebuffer at FOSDEM
2020 (https://fosdem.org/2020/schedule/event/fbdev).
> I replaced the "int" type by "float" for the zoom
variable in order to fill the entire screen when using 'f' or
'w' command.
> Thanks for this great tool !
I have seen the slides before by accident and enjoined it a lot.
Thanks for the presentation.
Personally I prefer not to use floating point types, unless
quite necessary; and if zoom is float, zoom_def and mark_row
have to be also. Instead, I changed them to store zoom level
in percentage. Please give it a try.
Ali
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEJB6CEALYECVDA3TTEN33RWSYDJANCNFSM4N4B52NQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fbpdf was used for my presentation on the Linux Framebuffer at FOSDEM 2020 (https://fosdem.org/2020/schedule/event/fbdev).
I replaced the "int" type by "float" for the zoom variable in order to fill the entire screen when using 'f' or 'w' command.
Thanks for this great tool !